You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/04/12 07:32:54 UTC

[GitHub] [submarine] jasoonn opened a new pull request #260: SUBMARINE-461. [WEB] Implement department page with Angular

jasoonn opened a new pull request #260: SUBMARINE-461. [WEB] Implement department page with Angular
URL: https://github.com/apache/submarine/pull/260
 
 
   ### What is this PR for?
   Implement frontend of department page in workbench with Angular.
   
   
   ### What type of PR is it?
   [Feature]
   
   ### Todos
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-461
   
   ### How should this be tested?
   [Travis]()
   
   ### Screenshots (if appropriate)
   ![](https://i.imgur.com/RiVPkKr.gif)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] liuxunorg commented on issue #260: SUBMARINE-461. [WEB] Implement department page with Angular

Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #260: SUBMARINE-461. [WEB] Implement department page with Angular
URL: https://github.com/apache/submarine/pull/260#issuecomment-612763295
 
 
   @jasoonn Thank you for contribution this feature.
   Will merge if no more comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] jasoonn commented on issue #260: SUBMARINE-461. [WEB] Implement department page with Angular

Posted by GitBox <gi...@apache.org>.
jasoonn commented on issue #260: SUBMARINE-461. [WEB] Implement department page with Angular
URL: https://github.com/apache/submarine/pull/260#issuecomment-612576497
 
 
   @liuxunorg @kobe860219 Can you help me review the pull request? Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] kobe860219 commented on issue #260: SUBMARINE-461. [WEB] Implement department page with Angular

Posted by GitBox <gi...@apache.org>.
kobe860219 commented on issue #260: SUBMARINE-461. [WEB] Implement department page with Angular
URL: https://github.com/apache/submarine/pull/260#issuecomment-612764970
 
 
   @jasoonn Thank you for contribution this feature. It is looks good to me.
   Is it need to add  blank line at the end of the file?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] jasoonn commented on issue #260: SUBMARINE-461. [WEB] Implement department page with Angular

Posted by GitBox <gi...@apache.org>.
jasoonn commented on issue #260: SUBMARINE-461. [WEB] Implement department page with Angular
URL: https://github.com/apache/submarine/pull/260#issuecomment-612767644
 
 
   @kobe860219 Thank you for the advice. I have added blank line at the end of the file, but it doesn't show here. Furthermore, I think it is ok, because there would appear "missing of end of line" in file changes part, if I didn't add blank line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] asfgit closed pull request #260: SUBMARINE-461. [WEB] Implement department page with Angular

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #260: SUBMARINE-461. [WEB] Implement department page with Angular
URL: https://github.com/apache/submarine/pull/260
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services