You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/09 17:26:03 UTC

[GitHub] [shardingsphere] Liangda-w opened a new pull request #10016: Complete Oracle drop table partition grammar

Liangda-w opened a new pull request #10016:
URL: https://github.com/apache/shardingsphere/pull/10016


   Related #9694 
   
   Sorry for being late🙏 I noticed #9940 has already done some changes to fix this issue, thank you @zhujunxxxxx. Please allow me to finish the following changes:
   
   - Complete `drop_table_partition`and add corresponding test cases 
   - Fix `addColumnSpecification`, as brackets are necessary here
   - Adjust `Literal.g4` for a clear separated definition for integer etc.
   - In `BaseRule.g4` `partition` and `partitionName` are used exactly in the same way, for consistency I removed one of the duplicates 
   
   Could you please review it :) @tristaZero @wgy8283335 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] wgy8283335 commented on pull request #10016: Complete Oracle drop table partition grammar

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on pull request #10016:
URL: https://github.com/apache/shardingsphere/pull/10016#issuecomment-817231031


   > Related #9694
   > 
   > Sorry for being late I noticed #9940 has already done some changes to fix this issue, thank you @zhujunxxxxx. Please allow me to finish the following changes:
   > 
   > * Complete `drop_table_partition` of [ALTER TABLE](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/ALTER-TABLE.html#GUID-552E7373-BF93-477D-9DA3-B2C9386F2877) and add corresponding test cases
   > * Fix `addColumnSpecification`, as brackets are necessary here
   > * Adjust `Literal.g4` for a clear separated definition for integer etc.
   > * In `BaseRule.g4` `partition` and `partitionName` are used exactly in the same way, for consistency I removed one of the duplicates
   > 
   > Could you please review it :) @tristaZero @wgy8283335
   
   Could you split the pr into 4 pull requests, as you mentioned that there mainly 4 changes in the pr?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] Liangda-w closed pull request #10016: Complete Oracle drop table partition grammar

Posted by GitBox <gi...@apache.org>.
Liangda-w closed pull request #10016:
URL: https://github.com/apache/shardingsphere/pull/10016


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] Liangda-w commented on pull request #10016: Complete Oracle drop table partition grammar

Posted by GitBox <gi...@apache.org>.
Liangda-w commented on pull request #10016:
URL: https://github.com/apache/shardingsphere/pull/10016#issuecomment-817719359


   > Could you split the pr into 4 pull requests, as you mentioned that there mainly 4 changes in the pr?
   
   @wgy8283335 okay, I'll do it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] Liangda-w commented on pull request #10016: Complete Oracle drop table partition grammar

Posted by GitBox <gi...@apache.org>.
Liangda-w commented on pull request #10016:
URL: https://github.com/apache/shardingsphere/pull/10016#issuecomment-816845276


   Beside this, I have a question: I saw in some cases the following warning:
   
   ```
   rule XXX contains an optional block with at least one alternative that can match an empty string
   ```
   
   Is this a big problem? Actually I think that we can't avoid this as some alternative indeed can match an empty string for example in case of `inmemoryTableClause`:
   
   ![image](https://user-images.githubusercontent.com/66914151/114219257-b78d3580-996a-11eb-8585-9924aa8589f6.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org