You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "jiang1997 (via GitHub)" <gi...@apache.org> on 2026/10/02 19:51:14 UTC

[PR] fix(desktop): align default project badge with row actions [maka]

jiang1997 opened a new pull request, #5944:
URL: https://github.com/apache/maka/pull/5944

   ## Summary
   
   Selecting a default project in the desktop Workspace page replaces “Set as default” with a shorter “Default” badge whose vertical center sits 4px above the adjacent More actions button. Wrap both controls in an HStack with center alignment and the standard action gap so either state remains vertically aligned.
   
   ## Verification
   
   - Browser layout check using the actual ListItem, Badge, Button, and MoreMenu components with installed Astryx and Maka styles in headless Chrome passed:
   
     | State | Vertical center difference before | After |
     | --- | ---: | ---: |
     | Set as default / More actions | 0px | 0px |
     | Default / More actions | 4px | 0px |
   
   - `git diff main...HEAD --check` passed.
   - Commit hooks passed ASF header and protocol epoch checks.
   - `npx tsc -p apps/desktop/tsconfig.renderer.json --noEmit` did not pass because of errors outside the changed file, including runtime-host protocol exports and the missing `@xterm/addon-web-links` dependency. No errors were reported in `projects-settings-page.tsx`.
   - No persistent regression test was added for this small layout change; the browser measurement above verified both states before and after.
   
   ## AI use
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: OpenAI Codex inspected the layout, implemented the HStack wrapper, verified browser geometry, and prepared this PR. The commit includes a `Generated-by: OpenAI Codex` trailer.
   
   ## Checklist
   
   - [ ] Tests cover the change and fail without it
   - [ ] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(desktop): align default project badge with row actions [maka]

Posted by "github-actions[bot] (via GitHub) via commits" <co...@maka.apache.org>.
github-actions[bot] commented on PR #5944:
URL: https://github.com/apache/maka/pull/5944#issuecomment-6568508847

   <!-- maka-lifecycle:stale-warning -->
   This pull request has had no new commits for 30 days and has been marked stale. It will be closed in 7 days unless a new commit is pushed.
   
   Comments do not reset this timer: only a new commit does. If the pull request is intentionally long-lived, a maintainer can apply the `pinned` label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org