You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/23 18:11:32 UTC

[GitHub] [arrow] bkietz commented on a change in pull request #8122: ARROW-9557: [R] Iterating over parquet columns is slow in R

bkietz commented on a change in pull request #8122:
URL: https://github.com/apache/arrow/pull/8122#discussion_r493791622



##########
File path: cpp/src/parquet/arrow/reader.cc
##########
@@ -174,10 +174,10 @@ class FileReaderImpl : public FileReader {
   Status BoundsCheck(const std::vector<int>& row_groups,
                      const std::vector<int>& column_indices) {
     for (int i : row_groups) {
-      return BoundsCheckRowGroup(i);
+      RETURN_NOT_OK(BoundsCheckRowGroup(i));

Review comment:
       No need to wait. That's an embarrassing bug, thanks for catching it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org