You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Sean Chou (JIRA)" <ji...@apache.org> on 2010/09/26 08:54:32 UTC
[jira] Created: (HARMONY-6657) A batch of testcases to increase rmi
module test coverage
A batch of testcases to increase rmi module test coverage
---------------------------------------------------------
Key: HARMONY-6657
URL: https://issues.apache.org/jira/browse/HARMONY-6657
Project: Harmony
Issue Type: Test
Components: Classlib
Environment: x86-32, windows xp and linux.
Reporter: Sean Chou
Priority: Trivial
This is a batch of testcase for rmi module to increase its method coverage. This batch of testcases are simple and don't contain multiprocess communication like rmid or rmiregistry. These testcases are tested under windowsxp and linux on x86_32.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6657) A batch of testcases to increase
rmi module test coverage
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu reassigned HARMONY-6657:
---------------------------------
Assignee: Regis Xu
> A batch of testcases to increase rmi module test coverage
> ---------------------------------------------------------
>
> Key: HARMONY-6657
> URL: https://issues.apache.org/jira/browse/HARMONY-6657
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Environment: x86-32, windows xp and linux.
> Reporter: Sean Chou
> Assignee: Regis Xu
> Priority: Trivial
> Fix For: 5.0M16
>
> Attachments: activationGroupIDTest.patch, dgcclassesTests.patch, exceptionclassTests.patch, rmi_testcases.patch, rmiserverpkgTests.patch
>
>
> This is a batch of testcase for rmi module to increase its method coverage. This batch of testcases are simple and don't contain multiprocess communication like rmid or rmiregistry. These testcases are tested under windowsxp and linux on x86_32.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-6657) A batch of testcases to increase
rmi module test coverage
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu resolved HARMONY-6657.
-------------------------------
Fix Version/s: 5.0M16
Resolution: Fixed
Hi Sean,
Thanks for your contribution! These patches were applied to trunk at r1002488, please verify.
> A batch of testcases to increase rmi module test coverage
> ---------------------------------------------------------
>
> Key: HARMONY-6657
> URL: https://issues.apache.org/jira/browse/HARMONY-6657
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Environment: x86-32, windows xp and linux.
> Reporter: Sean Chou
> Assignee: Regis Xu
> Priority: Trivial
> Fix For: 5.0M16
>
> Attachments: activationGroupIDTest.patch, dgcclassesTests.patch, exceptionclassTests.patch, rmi_testcases.patch, rmiserverpkgTests.patch
>
>
> This is a batch of testcase for rmi module to increase its method coverage. This batch of testcases are simple and don't contain multiprocess communication like rmid or rmiregistry. These testcases are tested under windowsxp and linux on x86_32.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6657) A batch of testcases to increase rmi
module test coverage
Posted by "Sean Chou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Chou updated HARMONY-6657:
-------------------------------
Attachment: rmiserverpkgTests.patch
Testcases for classes in java.rmi.server package.
> A batch of testcases to increase rmi module test coverage
> ---------------------------------------------------------
>
> Key: HARMONY-6657
> URL: https://issues.apache.org/jira/browse/HARMONY-6657
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Environment: x86-32, windows xp and linux.
> Reporter: Sean Chou
> Priority: Trivial
> Attachments: activationGroupIDTest.patch, dgcclassesTests.patch, exceptionclassTests.patch, rmi_testcases.patch, rmiserverpkgTests.patch
>
>
> This is a batch of testcase for rmi module to increase its method coverage. This batch of testcases are simple and don't contain multiprocess communication like rmid or rmiregistry. These testcases are tested under windowsxp and linux on x86_32.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6657) A batch of testcases to increase rmi
module test coverage
Posted by "Sean Chou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Chou updated HARMONY-6657:
-------------------------------
Attachment: exceptionclassTests.patch
activationGroupIDTest.patch
dgcclassesTests.patch
I modified the testcases according to the comment, and split the patch into small patches.
exceptionclassTests.patch includes some exception classes;
dgcclassesTests.patch includes tests for java.rmi.dgc.*;
activationGroupIDTest.patch tests ActivationGroupID.
rmiserverpkgTests.patch includes testcases for java.rmi.server.* classes.
About the catch in following test, it is necessary, because the result of isUnique method depends on the behavior of InetAddress.getLocalHost() .
"
+ public void testIsUnique(){
+ VMID vmid = new VMID();
+ boolean unique = true;
+ try {
+ InetAddress.getLocalHost();
+ } catch (Exception ex) {
+ unique = false;
+ }
+
+ assertTrue(unique == vmid.isUnique());
+ }
the catch is really necessary?
"
> A batch of testcases to increase rmi module test coverage
> ---------------------------------------------------------
>
> Key: HARMONY-6657
> URL: https://issues.apache.org/jira/browse/HARMONY-6657
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Environment: x86-32, windows xp and linux.
> Reporter: Sean Chou
> Priority: Trivial
> Attachments: activationGroupIDTest.patch, dgcclassesTests.patch, exceptionclassTests.patch, rmi_testcases.patch, rmiserverpkgTests.patch
>
>
> This is a batch of testcase for rmi module to increase its method coverage. This batch of testcases are simple and don't contain multiprocess communication like rmid or rmiregistry. These testcases are tested under windowsxp and linux on x86_32.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6657) A batch of testcases to increase
rmi module test coverage
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916705#action_12916705 ]
Hudson commented on HARMONY-6657:
---------------------------------
Integrated in Harmony-1.5-head-linux-x86_64 #973 (See [https://hudson.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/973/])
Apply patches for HARMONY-6657: A batch of testcases to increase rmi module test coverage
> A batch of testcases to increase rmi module test coverage
> ---------------------------------------------------------
>
> Key: HARMONY-6657
> URL: https://issues.apache.org/jira/browse/HARMONY-6657
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Environment: x86-32, windows xp and linux.
> Reporter: Sean Chou
> Assignee: Regis Xu
> Priority: Trivial
> Fix For: 5.0M16
>
> Attachments: activationGroupIDTest.patch, dgcclassesTests.patch, exceptionclassTests.patch, rmi_testcases.patch, rmiserverpkgTests.patch
>
>
> This is a batch of testcase for rmi module to increase its method coverage. This batch of testcases are simple and don't contain multiprocess communication like rmid or rmiregistry. These testcases are tested under windowsxp and linux on x86_32.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6657) A batch of testcases to increase
rmi module test coverage
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915095#action_12915095 ]
Regis Xu commented on HARMONY-6657:
-----------------------------------
some comments for test cases:
+ public void testGetSystem(){
+
+ try {
+ ActivationSystem as = new MyActivationSystem();
+ ActivationGroupID agid = new ActivationGroupID(as);
+
+ assertSame(as, agid.getSystem());
+ } catch (ActivationException e) {
+ fail();
+ }
+ }
actually you don't need to catch the exception, just let it go, junit will handle it correctly.
+ assertTrue(!vmid.toString().equals(vmid2.toString()));
Why not assertFalse?
+ public void testIsUnique(){
+ VMID vmid = new VMID();
+ boolean unique = true;
+ try {
+ InetAddress.getLocalHost();
+ } catch (Exception ex) {
+ unique = false;
+ }
+
+ assertTrue(unique == vmid.isUnique());
+ }
the catch is really necessary?
> A batch of testcases to increase rmi module test coverage
> ---------------------------------------------------------
>
> Key: HARMONY-6657
> URL: https://issues.apache.org/jira/browse/HARMONY-6657
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Environment: x86-32, windows xp and linux.
> Reporter: Sean Chou
> Priority: Trivial
> Attachments: rmi_testcases.patch
>
>
> This is a batch of testcase for rmi module to increase its method coverage. This batch of testcases are simple and don't contain multiprocess communication like rmid or rmiregistry. These testcases are tested under windowsxp and linux on x86_32.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6657) A batch of testcases to increase
rmi module test coverage
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916686#action_12916686 ]
Hudson commented on HARMONY-6657:
---------------------------------
Integrated in Harmony-select-1.5-head-linux-x86_64 #126 (See [https://hudson.apache.org/hudson/job/Harmony-select-1.5-head-linux-x86_64/126/])
Apply patches for HARMONY-6657: A batch of testcases to increase rmi module test coverage
> A batch of testcases to increase rmi module test coverage
> ---------------------------------------------------------
>
> Key: HARMONY-6657
> URL: https://issues.apache.org/jira/browse/HARMONY-6657
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Environment: x86-32, windows xp and linux.
> Reporter: Sean Chou
> Assignee: Regis Xu
> Priority: Trivial
> Fix For: 5.0M16
>
> Attachments: activationGroupIDTest.patch, dgcclassesTests.patch, exceptionclassTests.patch, rmi_testcases.patch, rmiserverpkgTests.patch
>
>
> This is a batch of testcase for rmi module to increase its method coverage. This batch of testcases are simple and don't contain multiprocess communication like rmid or rmiregistry. These testcases are tested under windowsxp and linux on x86_32.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6657) A batch of testcases to increase rmi
module test coverage
Posted by "Sean Chou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Chou updated HARMONY-6657:
-------------------------------
Attachment: rmi_testcases.patch
To increase the coverage of rmi module.
> A batch of testcases to increase rmi module test coverage
> ---------------------------------------------------------
>
> Key: HARMONY-6657
> URL: https://issues.apache.org/jira/browse/HARMONY-6657
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Environment: x86-32, windows xp and linux.
> Reporter: Sean Chou
> Priority: Trivial
> Attachments: rmi_testcases.patch
>
>
> This is a batch of testcase for rmi module to increase its method coverage. This batch of testcases are simple and don't contain multiprocess communication like rmid or rmiregistry. These testcases are tested under windowsxp and linux on x86_32.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.