You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/13 11:22:22 UTC
[GitHub] [flink] vthinkxie opened a new pull request #10842:
[FLINK-15489][web]: add cache control no-cache to log api
vthinkxie opened a new pull request #10842: [FLINK-15489][web]: add cache control no-cache to log api
URL: https://github.com/apache/flink/pull/10842
## What is the purpose of the change
fix https://issues.apache.org/jira/browse/FLINK-14270
## Brief change log
support more metric display at once
## Verifying this change
- *Go to the log page*
- *Click the refresh button*
- *Check the network panel if the log with no-cache header*
before:
<img width="1022" alt="before" src="https://user-images.githubusercontent.com/1506722/72252288-f7674f00-3639-11ea-9861-93157e789082.png">
after:
<img width="1190" alt="after" src="https://user-images.githubusercontent.com/1506722/72252293-fa623f80-3639-11ea-8a8a-049bf09b2677.png">
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10842:
[FLINK-15489][web]: add cache control no-cache to log api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10842: [FLINK-15489][web]: add cache control no-cache to log api
URL: https://github.com/apache/flink/pull/10842#issuecomment-573632115
<!--
Meta data
Hash:fbc3d61dc5657907e9e55497cf70431ceff2d2d9 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4293 TriggerType:PUSH TriggerID:fbc3d61dc5657907e9e55497cf70431ceff2d2d9
Hash:fbc3d61dc5657907e9e55497cf70431ceff2d2d9 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144140079 TriggerType:PUSH TriggerID:fbc3d61dc5657907e9e55497cf70431ceff2d2d9
-->
## CI report:
* fbc3d61dc5657907e9e55497cf70431ceff2d2d9 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144140079) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4293)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL edited a comment on issue #10842: [FLINK-15489][web]:
add cache control no-cache to log api
Posted by GitBox <gi...@apache.org>.
GJL edited a comment on issue #10842: [FLINK-15489][web]: add cache control no-cache to log api
URL: https://github.com/apache/flink/pull/10842#issuecomment-574580660
I should add that for the TM logs caching was not an issue before. `AbstractTaskManagerFileHandler` does not seem to set the Cache-Control header. I think it doesn't hurt to set `Cache-Control: no-cache` for both cases, however.
@vthinkxie Should we also backport this to 1.9?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] vthinkxie commented on issue #10842: [FLINK-15489][web]:
add cache control no-cache to log api
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on issue #10842: [FLINK-15489][web]: add cache control no-cache to log api
URL: https://github.com/apache/flink/pull/10842#issuecomment-574705800
yes, I think we should backport this to 1.9 if it could fix the cache problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on issue #10842: [FLINK-15489][web]: add
cache control no-cache to log api
Posted by GitBox <gi...@apache.org>.
GJL commented on issue #10842: [FLINK-15489][web]: add cache control no-cache to log api
URL: https://github.com/apache/flink/pull/10842#issuecomment-574580660
I should add that for the TM logs caching was not an issue before. `AbstractTaskManagerFileHandler` does not seem to set the Cache-Control header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL edited a comment on issue #10842: [FLINK-15489][web]:
add cache control no-cache to log api
Posted by GitBox <gi...@apache.org>.
GJL edited a comment on issue #10842: [FLINK-15489][web]: add cache control no-cache to log api
URL: https://github.com/apache/flink/pull/10842#issuecomment-574580660
I should add that for the TM logs caching was not an issue before. `AbstractTaskManagerFileHandler` does not seem to set the Cache-Control header. I think it doesn't hurt to set `Cache-Control: no-cache` for both cases, however.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on issue #10842: [FLINK-15489][web]: add
cache control no-cache to log api
Posted by GitBox <gi...@apache.org>.
GJL commented on issue #10842: [FLINK-15489][web]: add cache control no-cache to log api
URL: https://github.com/apache/flink/pull/10842#issuecomment-574578755
I can confirm that this change works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL closed pull request #10842: [FLINK-15489][web]: add
cache control no-cache to log api
Posted by GitBox <gi...@apache.org>.
GJL closed pull request #10842: [FLINK-15489][web]: add cache control no-cache to log api
URL: https://github.com/apache/flink/pull/10842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10842:
[FLINK-15489][web]: add cache control no-cache to log api
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10842: [FLINK-15489][web]: add cache control no-cache to log api
URL: https://github.com/apache/flink/pull/10842#issuecomment-573632115
<!--
Meta data
Hash:fbc3d61dc5657907e9e55497cf70431ceff2d2d9 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4293 TriggerType:PUSH TriggerID:fbc3d61dc5657907e9e55497cf70431ceff2d2d9
Hash:fbc3d61dc5657907e9e55497cf70431ceff2d2d9 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144140079 TriggerType:PUSH TriggerID:fbc3d61dc5657907e9e55497cf70431ceff2d2d9
-->
## CI report:
* fbc3d61dc5657907e9e55497cf70431ceff2d2d9 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144140079) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4293)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10842: [FLINK-15489][web]: add
cache control no-cache to log api
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10842: [FLINK-15489][web]: add cache control no-cache to log api
URL: https://github.com/apache/flink/pull/10842#issuecomment-573632115
<!--
Meta data
Hash:fbc3d61dc5657907e9e55497cf70431ceff2d2d9 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:fbc3d61dc5657907e9e55497cf70431ceff2d2d9
-->
## CI report:
* fbc3d61dc5657907e9e55497cf70431ceff2d2d9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL edited a comment on issue #10842: [FLINK-15489][web]:
add cache control no-cache to log api
Posted by GitBox <gi...@apache.org>.
GJL edited a comment on issue #10842: [FLINK-15489][web]: add cache control no-cache to log api
URL: https://github.com/apache/flink/pull/10842#issuecomment-574580660
I should add that for the TM logs caching was not an issue before. `AbstractTaskManagerFileHandler` does not seem to set the Cache-Control header. I think it doesn't hurt to set `Cache-Control: no-cache`, however.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10842: [FLINK-15489][web]: add
cache control no-cache to log api
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10842: [FLINK-15489][web]: add cache control no-cache to log api
URL: https://github.com/apache/flink/pull/10842#issuecomment-573618229
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit fbc3d61dc5657907e9e55497cf70431ceff2d2d9 (Mon Jan 13 11:25:21 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15489).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services