[GitHub] [hive] saihemanth-cloudera commented on a diff in pull request #4572: HIVE-27525:Ease the write permissions on external table during create table operation

["saihemanth-cloudera (via GitHub)" <gi...@apache.org>]

saihemanth-cloudera commented on code in PR #4572:
URL: https://github.com/apache/hive/pull/4572#discussion_r1289025843


##########
ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/TestHiveMetaStoreAuthorizer.java:
##########
@@ -133,6 +133,22 @@ public void testB_CreateTable_unAuthorizedUser() throws Exception {
     }
   }
 
+  @Test
+  public void testI_CreateExternalTable_authorizedUser() throws Exception {
+    UserGroupInformation.setLoginUser(UserGroupInformation.createRemoteUser(authorizedUser));
+    try {
+      Table table = new TableBuilder()
+              .setTableName(tblName)
+              .setType(TableType.EXTERNAL_TABLE.name())
+              .addCol("name", ColumnType.STRING_TYPE_NAME)
+              .setOwner(authorizedUser)
+              .build(conf);
+      hmsHandler.create_table(table);

Review Comment:
   Is this test required? because we are not specifying the external table location here with reduced permissions? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org