[jira] [Resolved] (WICKET-6214) ModalWindow broken on IE

["Sven Meier (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sven Meier resolved WICKET-6214.
--------------------------------
       Resolution: Fixed
         Assignee: Sven Meier  (was: Martin Grigorov)
    Fix Version/s: 7.5.0
                   6.25.0
                   8.0.0-M2

Event.fix() is now reverted to the previous behavior, e.g. always fix the event.

To my reading jQuery does not re-fix an already fixed event, so there is no danger in calling it again.

Although we could fix ModalWindow instead, IMHO we should not change the behavior of this method, as we don't know who is calling it.

> ModalWindow broken on IE
> ------------------------
>
>                 Key: WICKET-6214
>                 URL: https://issues.apache.org/jira/browse/WICKET-6214
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.23.0, 6.24.0
>            Reporter: Sven Meier
>            Assignee: Sven Meier
>            Priority: Minor
>             Fix For: 8.0.0-M2, 6.25.0, 7.5.0
>
>
> Since WICKET-6108 wicket-event-jquery.js no longer fixes passed in events:
> {code}
> 	fix: function (evt) {
> -		var evnt = evt || window.event;
> -		return jQuery.event.fix(evnt);
> +		return evt || jQuery.event.fix(window.event);
>  	},
> {code}
> But modal.js directly invokes {{Wicket.Event#stop()}}:
> {code}
>  	onmousedown=\"Wicket.Event.stop(event);\"
> {code}
> Thus the event is not 'fixed', but {{#stopPropagation()}} is called on it:
> {code}
> 	stop: function (evt, immediate) {
> 		evt = Wicket.Event.fix(evt);
> 		if (immediate) {
> 			evt.stopImmediatePropagation();
> 		} else {
> 			evt.stopPropagation();
> 		}
> 		return evt;
> 	},
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)