(commons-lang) branch master updated: Fix internal inverted logic in private isEnum() method and correct its usage in getFirstEnum() (#1454)

[gg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git


The following commit(s) were added to refs/heads/master by this push:
     new 6513eb0bb Fix internal inverted logic in private isEnum() method and correct its usage in getFirstEnum() (#1454)
6513eb0bb is described below

commit 6513eb0bbb4b3e8d427cce632f786c115f2a3516
Author: mayuming <ka...@163.com>
AuthorDate: Mon Sep 29 19:17:57 2025 +0800

    Fix internal inverted logic in private isEnum() method and correct its usage in getFirstEnum() (#1454)
    
    * Optimize ObjectToStringComparator.compare() method
    
    * Fix inverted logic in isEnum() method and correct its usage in getFirstEnum()
---
 src/main/java/org/apache/commons/lang3/EnumUtils.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/commons/lang3/EnumUtils.java b/src/main/java/org/apache/commons/lang3/EnumUtils.java
index 36cf44d38..513b3140a 100644
--- a/src/main/java/org/apache/commons/lang3/EnumUtils.java
+++ b/src/main/java/org/apache/commons/lang3/EnumUtils.java
@@ -343,7 +343,7 @@ public static <E extends Enum<E>> E getEnumSystemProperty(final Class<E> enumCla
      * @since 3.18.0
      */
     public static <E extends Enum<E>> E getFirstEnum(final Class<E> enumClass, final int value, final ToIntFunction<E> toIntFunction, final E defaultEnum) {
-        if (isEnum(enumClass)) {
+        if (!isEnum(enumClass)) {
             return defaultEnum;
         }
         return stream(enumClass).filter(e -> value == toIntFunction.applyAsInt(e)).findFirst().orElse(defaultEnum);
@@ -372,7 +372,7 @@ public static <E extends Enum<E>> E getFirstEnumIgnoreCase(final Class<E> enumCl
     }
 
     private static <E extends Enum<E>> boolean isEnum(final Class<E> enumClass) {
-        return enumClass != null && !enumClass.isEnum();
+        return enumClass != null && enumClass.isEnum();
     }
 
     /**