You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "codelipenghui (via GitHub)" <gi...@apache.org> on 2023/10/07 03:23:30 UTC

[PR] Revert "[fix][broker] Miss headersAndPayload and messageIdData in MessagePublishContext (#21245) [pulsar]

codelipenghui opened a new pull request, #21309:
URL: https://github.com/apache/pulsar/pull/21309

   ### Motivation
   
   Please see: https://github.com/apache/pulsar/pull/21245#issuecomment-1751580685 and https://github.com/apache/pulsar/pull/21263#pullrequestreview-1662988197
   
   ### Modifications
   
   Revert: #21245
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert "[fix][broker] Miss headersAndPayload and messageIdData in MessagePublishContext (#21245) [pulsar]

Posted by "codelipenghui (via GitHub)" <gi...@apache.org>.
codelipenghui commented on PR #21309:
URL: https://github.com/apache/pulsar/pull/21309#issuecomment-1751582803

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert "[fix][broker] Miss headersAndPayload and messageIdData in MessagePublishContext (#21245) [pulsar]

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #21309:
URL: https://github.com/apache/pulsar/pull/21309#issuecomment-1751665693

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert "[fix][broker] Miss headersAndPayload and messageIdData in MessagePublishContext (#21245) [pulsar]

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece merged PR #21309:
URL: https://github.com/apache/pulsar/pull/21309


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert "[fix][broker] Miss headersAndPayload and messageIdData in MessagePublishContext (#21245) [pulsar]

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #21309:
URL: https://github.com/apache/pulsar/pull/21309#issuecomment-1751902884

   I think we should add `@Test(groups = "flaky")` to  `NarUnpackerTest` to avoid the CI being blocked.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org