You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/01 06:09:12 UTC
[GitHub] [arrow] kambhamvivekshankar opened a new pull request, #14557: ARROW-18209: [Java] Make ComplexCopier agnostic of specific implementation of MapWriter (UnionMapWriter)
kambhamvivekshankar opened a new pull request, #14557:
URL: https://github.com/apache/arrow/pull/14557
Making ComplexCopier independent of UnionMapWriter lets us use different implementations, like PromotableWriter instead. This helps us to copy map vector with a map value. Otherwise we get the following error: ClassCast class org.apache.arrow.vector.complex.impl.PromotableWriter cannot be cast to class org.apache.arrow.vector.complex.impl.UnionMapWriter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pprudhvi commented on pull request #14557: ARROW-18209: [Java] Make ComplexCopier agnostic of specific implementation of MapWriter (UnionMapWriter)
Posted by GitBox <gi...@apache.org>.
pprudhvi commented on PR #14557:
URL: https://github.com/apache/arrow/pull/14557#issuecomment-1302013103
@lidavidm @pitrou could you please review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14557: ARROW-18209: [Java] Make ComplexCopier agnostic of specific implementation of MapWriter (UnionMapWriter)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14557:
URL: https://github.com/apache/arrow/pull/14557#issuecomment-1307720557
Benchmark runs are scheduled for baseline = 89a65b06a199f10274a562df3dd24c62f2ac0a6a and contender = 8a5aa6718295eaa3f336125eace4a343a65c922f. 8a5aa6718295eaa3f336125eace4a343a65c922f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b33d61917b32488e97a1362690e859e6...23ee089979ce400eabc2f043de386342/)
[Finished :arrow_down:0.44% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/55a2c75713ca429699b6b059392ac960...aafde415ebd04b66a3fee03dd17944df/)
[Finished :arrow_down:0.0% :arrow_up:0.27%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f32e0db127ad42a69c14673496d7a134...3bbb0e6e2d4c4b93aaedf1ccbdd685ff/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1d04880340ab4db780d914c57aef7e23...f01bbec0a59c40cdb1729fdb90073675/)
Buildkite builds:
[Finished] [`8a5aa671` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1831)
[Finished] [`8a5aa671` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1853)
[Finished] [`8a5aa671` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1819)
[Failed] [`8a5aa671` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1845)
[Finished] [`89a65b06` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1830)
[Finished] [`89a65b06` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1852)
[Finished] [`89a65b06` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1818)
[Finished] [`89a65b06` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1844)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #14557: ARROW-18209: [Java] Make ComplexCopier agnostic of specific implementation of MapWriter (UnionMapWriter)
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #14557:
URL: https://github.com/apache/arrow/pull/14557#issuecomment-1302119601
CC @lwhite1 @davisusanibar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14557: ARROW-18209: [Java] Make ComplexCopier agnostic of specific implementation of MapWriter (UnionMapWriter)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14557:
URL: https://github.com/apache/arrow/pull/14557#issuecomment-1298078160
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14557: ARROW-18209: [Java] Make ComplexCopier agnostic of specific implementation of MapWriter (UnionMapWriter)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14557:
URL: https://github.com/apache/arrow/pull/14557#issuecomment-1298078125
https://issues.apache.org/jira/browse/ARROW-18209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #14557: ARROW-18209: [Java] Make ComplexCopier agnostic of specific implementation of MapWriter (UnionMapWriter)
Posted by GitBox <gi...@apache.org>.
lidavidm merged PR #14557:
URL: https://github.com/apache/arrow/pull/14557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org