You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2023/01/17 20:29:13 UTC
[GitHub] [tinkerpop] Cole-Greer opened a new pull request, #1947: Adds CodeQL vulnerability scanning to Github Actions
Cole-Greer opened a new pull request, #1947:
URL: https://github.com/apache/tinkerpop/pull/1947
Adds new workflow which runs CodeQL vulnerability scanning on any pushes or pull requests to master, 3.5-dev, or 3.6-dev.
Also includes a small fix in go to prevent a possible lossy type conversion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy merged pull request #1947: Adds CodeQL vulnerability scanning to Github Actions
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy merged PR #1947:
URL: https://github.com/apache/tinkerpop/pull/1947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer commented on a diff in pull request #1947: Adds CodeQL vulnerability scanning to Github Actions
Posted by GitBox <gi...@apache.org>.
Cole-Greer commented on code in PR #1947:
URL: https://github.com/apache/tinkerpop/pull/1947#discussion_r1073852728
##########
.github/workflows/codeql.yml:
##########
@@ -0,0 +1,104 @@
+name: "CodeQL"
+
+on:
+ push:
+ branches: [ "master", "3.5-dev", "3.6-dev" ]
+ pull_request:
+ # The branches below must be a subset of the branches above
+ branches: [ "master", "3.5-dev", "3.6-dev" ]
+ schedule:
+ - cron: '22 8 * * 1'
+
+jobs:
+ analyze:
+ name: Analyze
+ runs-on: ubuntu-latest
+ permissions:
+ actions: read
+ contents: read
+ security-events: write
+
+ strategy:
+ fail-fast: false
+ matrix:
+ language: [ 'go', 'java', 'javascript', 'python' ]
+ # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
+ # Use only 'java' to analyze code written in Java, Kotlin or both
+ # Use only 'javascript' to analyze code written in JavaScript, TypeScript or both
+ # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support
+
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@v3
+
+ # Initializes the CodeQL tools for scanning.
+ - name: Initialize CodeQL
+ uses: github/codeql-action/init@v2
+ with:
+ languages: ${{ matrix.language }}
+ # If you wish to specify custom queries, you can do so here or in a config file.
+ # By default, queries listed here will override any specified in a config file.
+ # Prefix the list here with "+" to use these queries and those in the config file.
+
+ # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
+ # queries: security-extended,security-and-quality
+
+
+ # Autobuild attempts to build any compiled languages (C/C++, C#, Go, or Java).
+ # If this step fails, then you should remove it and run the build manually (see below)
+ - name: Autobuild
+ uses: github/codeql-action/autobuild@v2
+
+ # ℹ️ Command-line programs to run using the OS shell.
+ # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
+
+ # If the Autobuild fails above, remove it and uncomment the following three lines.
+ # modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
+
+ # - run: |
+ # echo "Run, Build Application using script"
+ # ./location_of_script_within_repo/buildscript.sh
+
+ - name: Perform CodeQL Analysis
+ uses: github/codeql-action/analyze@v2
+ with:
+ category: "/language:${{matrix.language}}"
+
+ # .Net is run as a separate job as the integration tests take far too long to build
+ analyze_dotnet:
+ name: Analyze .Net
+ runs-on: ubuntu-latest
+ permissions:
+ actions: read
+ contents: read
+ security-events: write
+
+ strategy:
+ fail-fast: false
+ matrix:
Review Comment:
The `matrix` here is unnecessary. My reasoning for including it was in case eventually another language also needs to be excluded from autobuild. I don't have a strong preference either way. I will remove the `matrix` to simplify the current version of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1947: Adds CodeQL vulnerability scanning to Github Actions
Posted by GitBox <gi...@apache.org>.
FlorianHockmann commented on PR #1947:
URL: https://github.com/apache/tinkerpop/pull/1947#issuecomment-1396535991
> The diagnostics here is referring to what code it was able to analyze, not what the results of that analysis was. The extraction error there means that there was one file which codeQL failed to extract for analysis. We could potentially learn more from running codeQL in debug mode. According to the codeQL [docs](https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/troubleshooting-the-codeql-workflow#extraction-errors-in-the-database): "A small number of extractor errors is healthy and typically indicates a good state of analysis."
Thanks for the explanation, that's good to know.
> All of the analysis results for the repo are also collected in the security tab [here](https://github.com/apache/tinkerpop/security/code-scanning). (Hopefully that link works, it is only accessible to committers).
Yep, that's working. Looks good to me.
I also agree with your assessment of the 3 warnings it found. I'll just leave the Go one open for someone with more Go experience to confirm & mark as a FP.
Overall, this is good to go from my side. VOTE +1
But this probably has to wait a bit as we're currently in code freeze.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on a diff in pull request #1947: Adds CodeQL vulnerability scanning to Github Actions
Posted by GitBox <gi...@apache.org>.
FlorianHockmann commented on code in PR #1947:
URL: https://github.com/apache/tinkerpop/pull/1947#discussion_r1073629543
##########
.github/workflows/codeql.yml:
##########
@@ -0,0 +1,104 @@
+name: "CodeQL"
+
+on:
+ push:
+ branches: [ "master", "3.5-dev", "3.6-dev" ]
+ pull_request:
+ # The branches below must be a subset of the branches above
+ branches: [ "master", "3.5-dev", "3.6-dev" ]
+ schedule:
+ - cron: '22 8 * * 1'
+
+jobs:
+ analyze:
+ name: Analyze
+ runs-on: ubuntu-latest
+ permissions:
+ actions: read
+ contents: read
+ security-events: write
+
+ strategy:
+ fail-fast: false
+ matrix:
+ language: [ 'go', 'java', 'javascript', 'python' ]
+ # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
+ # Use only 'java' to analyze code written in Java, Kotlin or both
+ # Use only 'javascript' to analyze code written in JavaScript, TypeScript or both
+ # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support
+
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@v3
+
+ # Initializes the CodeQL tools for scanning.
+ - name: Initialize CodeQL
+ uses: github/codeql-action/init@v2
+ with:
+ languages: ${{ matrix.language }}
+ # If you wish to specify custom queries, you can do so here or in a config file.
+ # By default, queries listed here will override any specified in a config file.
+ # Prefix the list here with "+" to use these queries and those in the config file.
+
+ # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
+ # queries: security-extended,security-and-quality
+
+
+ # Autobuild attempts to build any compiled languages (C/C++, C#, Go, or Java).
+ # If this step fails, then you should remove it and run the build manually (see below)
+ - name: Autobuild
+ uses: github/codeql-action/autobuild@v2
+
+ # ℹ️ Command-line programs to run using the OS shell.
+ # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
+
+ # If the Autobuild fails above, remove it and uncomment the following three lines.
+ # modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
+
+ # - run: |
+ # echo "Run, Build Application using script"
+ # ./location_of_script_within_repo/buildscript.sh
+
+ - name: Perform CodeQL Analysis
+ uses: github/codeql-action/analyze@v2
+ with:
+ category: "/language:${{matrix.language}}"
+
+ # .Net is run as a separate job as the integration tests take far too long to build
+ analyze_dotnet:
+ name: Analyze .Net
+ runs-on: ubuntu-latest
+ permissions:
+ actions: read
+ contents: read
+ security-events: write
+
+ strategy:
+ fail-fast: false
+ matrix:
Review Comment:
Not that important, but does it really make sense to use `matrix` here if the `run` below is completely specific to .NET? I think it would be simpler without the `matrix`.
##########
.github/workflows/codeql.yml:
##########
@@ -0,0 +1,104 @@
+name: "CodeQL"
+
+on:
+ push:
+ branches: [ "master", "3.5-dev", "3.6-dev" ]
+ pull_request:
+ # The branches below must be a subset of the branches above
+ branches: [ "master", "3.5-dev", "3.6-dev" ]
+ schedule:
+ - cron: '22 8 * * 1'
+
+jobs:
+ analyze:
+ name: Analyze
+ runs-on: ubuntu-latest
+ permissions:
+ actions: read
+ contents: read
+ security-events: write
+
+ strategy:
+ fail-fast: false
+ matrix:
+ language: [ 'go', 'java', 'javascript', 'python' ]
+ # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
+ # Use only 'java' to analyze code written in Java, Kotlin or both
+ # Use only 'javascript' to analyze code written in JavaScript, TypeScript or both
+ # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support
+
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@v3
+
+ # Initializes the CodeQL tools for scanning.
+ - name: Initialize CodeQL
+ uses: github/codeql-action/init@v2
+ with:
+ languages: ${{ matrix.language }}
+ # If you wish to specify custom queries, you can do so here or in a config file.
+ # By default, queries listed here will override any specified in a config file.
+ # Prefix the list here with "+" to use these queries and those in the config file.
+
+ # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
+ # queries: security-extended,security-and-quality
+
+
+ # Autobuild attempts to build any compiled languages (C/C++, C#, Go, or Java).
+ # If this step fails, then you should remove it and run the build manually (see below)
+ - name: Autobuild
+ uses: github/codeql-action/autobuild@v2
+
+ # ℹ️ Command-line programs to run using the OS shell.
+ # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
+
+ # If the Autobuild fails above, remove it and uncomment the following three lines.
+ # modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
+
+ # - run: |
+ # echo "Run, Build Application using script"
+ # ./location_of_script_within_repo/buildscript.sh
+
+ - name: Perform CodeQL Analysis
+ uses: github/codeql-action/analyze@v2
+ with:
+ category: "/language:${{matrix.language}}"
+
+ # .Net is run as a separate job as the integration tests take far too long to build
Review Comment:
Hmm, that's unfortunate and I'm wondering why this is the case. The normal build without executing any tests usually shouldn't take long.
But sure, manually building .NET should also not be a problem.
##########
.github/workflows/codeql.yml:
##########
@@ -0,0 +1,104 @@
+name: "CodeQL"
+
+on:
+ push:
+ branches: [ "master", "3.5-dev", "3.6-dev" ]
+ pull_request:
+ # The branches below must be a subset of the branches above
+ branches: [ "master", "3.5-dev", "3.6-dev" ]
+ schedule:
+ - cron: '22 8 * * 1'
+
+jobs:
+ analyze:
+ name: Analyze
+ runs-on: ubuntu-latest
+ permissions:
+ actions: read
+ contents: read
+ security-events: write
+
+ strategy:
+ fail-fast: false
+ matrix:
+ language: [ 'go', 'java', 'javascript', 'python' ]
+ # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
+ # Use only 'java' to analyze code written in Java, Kotlin or both
+ # Use only 'javascript' to analyze code written in JavaScript, TypeScript or both
+ # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support
+
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@v3
+
+ # Initializes the CodeQL tools for scanning.
+ - name: Initialize CodeQL
+ uses: github/codeql-action/init@v2
+ with:
+ languages: ${{ matrix.language }}
+ # If you wish to specify custom queries, you can do so here or in a config file.
+ # By default, queries listed here will override any specified in a config file.
+ # Prefix the list here with "+" to use these queries and those in the config file.
+
+ # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
+ # queries: security-extended,security-and-quality
+
+
+ # Autobuild attempts to build any compiled languages (C/C++, C#, Go, or Java).
+ # If this step fails, then you should remove it and run the build manually (see below)
+ - name: Autobuild
+ uses: github/codeql-action/autobuild@v2
+
+ # ℹ️ Command-line programs to run using the OS shell.
+ # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
+
+ # If the Autobuild fails above, remove it and uncomment the following three lines.
+ # modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
+
+ # - run: |
+ # echo "Run, Build Application using script"
+ # ./location_of_script_within_repo/buildscript.sh
+
+ - name: Perform CodeQL Analysis
+ uses: github/codeql-action/analyze@v2
+ with:
+ category: "/language:${{matrix.language}}"
+
+ # .Net is run as a separate job as the integration tests take far too long to build
+ analyze_dotnet:
+ name: Analyze .Net
+ runs-on: ubuntu-latest
+ permissions:
+ actions: read
+ contents: read
+ security-events: write
+
+ strategy:
+ fail-fast: false
+ matrix:
+ language: [ 'csharp' ]
+
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@v3
+
+ # Initializes the CodeQL tools for scanning.
+ - name: Initialize CodeQL
+ uses: github/codeql-action/init@v2
+ with:
+ languages: ${{ matrix.language }}
+
+ - run: |
+ echo "Build .NET"
+ dotnet build gremlin-dotnet/src/Gremlin.Net;
+ dotnet build gremlin-dotnet/src/Gremlin.Net.Template
+ dotnet build gremlin-dotnet/test/Gremlin.Net.UnitTest
+ dotnet build gremlin-dotnet/test/Gremlin.Net.Benchmarks
+# Excluded due to extremely long (~45m) build time in github actions
Review Comment:
Wow, that's really extreme. Would be interesting to know of course what's taking so long here, but it's also not that important, especially for this PR. I also don't think that we really need to perform the scanning on test projects as we don't ship them to users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer commented on pull request #1947: Adds CodeQL vulnerability scanning to Github Actions
Posted by GitBox <gi...@apache.org>.
Cole-Greer commented on PR #1947:
URL: https://github.com/apache/tinkerpop/pull/1947#issuecomment-1387491400
> Thanks a lot for tackling this! The changes also look good to me basically. The .NET scan however includes this in its logs:
>
> ```
> Analysis produced the following diagnostic data:
>
> | Diagnostic | Summary |
> +------------------------------+--------------------+
> | Extraction errors | 1 result (1 error) |
> | Compilation error | 8 results |
> | Compilation message | 16 results |
> | Successfully extracted files | 272 results |
> ```
>
> Doesn't this mean that it found something? And shouldn't that be reported?
The diagnostics here is referring to what code it was able to analyze, not what the results of that analysis was. The extraction error there means that there was one file which codeQL failed to extract for analysis. We could potentially learn more from running codeQL in debug mode. According to the codeQL [docs](https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/troubleshooting-the-codeql-workflow#extraction-errors-in-the-database): "A small number of extractor errors is healthy and typically indicates a good state of analysis."
The results of a single job can be viewed from the "code scanning results" section of the checks tab ([here for this PR](https://github.com/apache/tinkerpop/pull/1947/checks?check_run_id=10709124951)).
All of the analysis results for the repo are also collected in the security tab [here](https://github.com/apache/tinkerpop/security/code-scanning). (Hopefully that link works, it is only accessible to committers).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #1947: Adds CodeQL vulnerability scanning to Github Actions
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #1947:
URL: https://github.com/apache/tinkerpop/pull/1947#issuecomment-1416339468
LGTM, merging this in now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer commented on a diff in pull request #1947: Adds CodeQL vulnerability scanning to Github Actions
Posted by GitBox <gi...@apache.org>.
Cole-Greer commented on code in PR #1947:
URL: https://github.com/apache/tinkerpop/pull/1947#discussion_r1073859847
##########
.github/workflows/codeql.yml:
##########
@@ -0,0 +1,104 @@
+name: "CodeQL"
+
+on:
+ push:
+ branches: [ "master", "3.5-dev", "3.6-dev" ]
+ pull_request:
+ # The branches below must be a subset of the branches above
+ branches: [ "master", "3.5-dev", "3.6-dev" ]
+ schedule:
+ - cron: '22 8 * * 1'
+
+jobs:
+ analyze:
+ name: Analyze
+ runs-on: ubuntu-latest
+ permissions:
+ actions: read
+ contents: read
+ security-events: write
+
+ strategy:
+ fail-fast: false
+ matrix:
+ language: [ 'go', 'java', 'javascript', 'python' ]
+ # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
+ # Use only 'java' to analyze code written in Java, Kotlin or both
+ # Use only 'javascript' to analyze code written in JavaScript, TypeScript or both
+ # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support
+
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@v3
+
+ # Initializes the CodeQL tools for scanning.
+ - name: Initialize CodeQL
+ uses: github/codeql-action/init@v2
+ with:
+ languages: ${{ matrix.language }}
+ # If you wish to specify custom queries, you can do so here or in a config file.
+ # By default, queries listed here will override any specified in a config file.
+ # Prefix the list here with "+" to use these queries and those in the config file.
+
+ # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
+ # queries: security-extended,security-and-quality
+
+
+ # Autobuild attempts to build any compiled languages (C/C++, C#, Go, or Java).
+ # If this step fails, then you should remove it and run the build manually (see below)
+ - name: Autobuild
+ uses: github/codeql-action/autobuild@v2
+
+ # ℹ️ Command-line programs to run using the OS shell.
+ # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
+
+ # If the Autobuild fails above, remove it and uncomment the following three lines.
+ # modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
+
+ # - run: |
+ # echo "Run, Build Application using script"
+ # ./location_of_script_within_repo/buildscript.sh
+
+ - name: Perform CodeQL Analysis
+ uses: github/codeql-action/analyze@v2
+ with:
+ category: "/language:${{matrix.language}}"
+
+ # .Net is run as a separate job as the integration tests take far too long to build
+ analyze_dotnet:
+ name: Analyze .Net
+ runs-on: ubuntu-latest
+ permissions:
+ actions: read
+ contents: read
+ security-events: write
+
+ strategy:
+ fail-fast: false
+ matrix:
+ language: [ 'csharp' ]
+
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@v3
+
+ # Initializes the CodeQL tools for scanning.
+ - name: Initialize CodeQL
+ uses: github/codeql-action/init@v2
+ with:
+ languages: ${{ matrix.language }}
+
+ - run: |
+ echo "Build .NET"
+ dotnet build gremlin-dotnet/src/Gremlin.Net;
+ dotnet build gremlin-dotnet/src/Gremlin.Net.Template
+ dotnet build gremlin-dotnet/test/Gremlin.Net.UnitTest
+ dotnet build gremlin-dotnet/test/Gremlin.Net.Benchmarks
+# Excluded due to extremely long (~45m) build time in github actions
Review Comment:
Yeah I was pretty surprised by that result but in my tests it was very consistent and reproducible. I'm sure a build system could be found which doesn't run into whatever bottleneck this is hitting. It doesn't seem like a much of a priority at this time though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #1947: Adds CodeQL vulnerability scanning to Github Actions
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1947:
URL: https://github.com/apache/tinkerpop/pull/1947#issuecomment-1386046034
# [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1947?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1947](https://codecov.io/gh/apache/tinkerpop/pull/1947?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84e7fed) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/b8e6b2827d68bfbc73205df00f201a0e75bd7ca2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8e6b28) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## 3.5-dev #1947 +/- ##
=============================================
+ Coverage 69.29% 69.33% +0.04%
- Complexity 8937 8957 +20
=============================================
Files 865 865
Lines 41086 41092 +6
Branches 5417 5418 +1
=============================================
+ Hits 28472 28493 +21
+ Misses 10696 10693 -3
+ Partials 1918 1906 -12
```
| [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [gremlin-go/driver/result.go](https://codecov.io/gh/apache/tinkerpop/pull/1947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvcmVzdWx0Lmdv) | `89.65% <100.00%> (ø)` | |
| [...ava/org/apache/tinkerpop/gremlin/util/Gremlin.java](https://codecov.io/gh/apache/tinkerpop/pull/1947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi91dGlsL0dyZW1saW4uamF2YQ==) | `50.00% <0.00%> (-10.00%)` | :arrow_down: |
| [...versal/step/map/PeerPressureVertexProgramStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL2NvbXB1dGVyL3RyYXZlcnNhbC9zdGVwL21hcC9QZWVyUHJlc3N1cmVWZXJ0ZXhQcm9ncmFtU3RlcC5qYXZh) | `65.85% <0.00%> (-4.88%)` | :arrow_down: |
| [...rg/apache/tinkerpop/gremlin/driver/Connection.java](https://codecov.io/gh/apache/tinkerpop/pull/1947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Db25uZWN0aW9uLmphdmE=) | `60.62% <0.00%> (-1.88%)` | :arrow_down: |
| [...pache/tinkerpop/gremlin/driver/ConnectionPool.java](https://codecov.io/gh/apache/tinkerpop/pull/1947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Db25uZWN0aW9uUG9vbC5qYXZh) | `29.28% <0.00%> (+0.62%)` | :arrow_up: |
| [...kergraph/process/computer/TinkerGraphComputer.java](https://codecov.io/gh/apache/tinkerpop/pull/1947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGlua2VyZ3JhcGgtZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vdGlua2VyZ3JhcGgvcHJvY2Vzcy9jb21wdXRlci9UaW5rZXJHcmFwaENvbXB1dGVyLmphdmE=) | `93.89% <0.00%> (+0.76%)` | :arrow_up: |
| [...e/tinkerpop/gremlin/server/util/MetricManager.java](https://codecov.io/gh/apache/tinkerpop/pull/1947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci91dGlsL01ldHJpY01hbmFnZXIuamF2YQ==) | `53.00% <0.00%> (+1.09%)` | :arrow_up: |
| [...in/process/traversal/dsl/graph/GraphTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/1947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9kc2wvZ3JhcGgvR3JhcGhUcmF2ZXJzYWwuamF2YQ==) | `91.17% <0.00%> (+1.26%)` | :arrow_up: |
| [...java/org/apache/tinkerpop/gremlin/driver/Host.java](https://codecov.io/gh/apache/tinkerpop/pull/1947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Ib3N0LmphdmE=) | `37.77% <0.00%> (+2.22%)` | :arrow_up: |
| [...org/apache/tinkerpop/gremlin/driver/UserAgent.java](https://codecov.io/gh/apache/tinkerpop/pull/1947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Vc2VyQWdlbnQuamF2YQ==) | `81.25% <0.00%> (+4.32%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/tinkerpop/pull/1947?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org