You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/02 07:15:48 UTC

[GitHub] [hudi] luoyajun526 commented on pull request #1677: [HUDI-934] Add processing logic for the decimal LogicalType

luoyajun526 commented on pull request #1677:
URL: https://github.com/apache/hudi/pull/1677#issuecomment-637340942


   > @leesf @luoyajun526 The code LGTM. But I think we need to make sure existing integration tests for MOR cover this case. The integration tests use `HoodieTestDataGenerator` to generate data. If we can modify the `trip schema` in `HoodieTestDataGenerator` to add a decimal field as well, I think this case will get covered through existing integration tests which test MOR table as well as perform upserts on them and then query using hive. If you don't want to block this PR on integration tests, we can open a JIRA for this.
   
   @umehrot2 @leesf Hi, I added a Jira for this review. HUDI-987


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org