You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/18 12:22:47 UTC

[GitHub] [maven-mvnd] gnodet commented on a change in pull request #585: Fix user's pronoun in mvnd.properties comment

gnodet commented on a change in pull request #585:
URL: https://github.com/apache/maven-mvnd/pull/585#discussion_r786698399



##########
File path: dist/src/main/distro/conf/mvnd.properties
##########
@@ -86,7 +86,7 @@
 # MVND_MIN_THREADS
 # The minimum number of threads to use when constructing the default {@code -T} parameter for the daemon.
 # This value is ignored if the user passes @{@code -T}, @{@code --threads} or {@code -Dmvnd.threads} on the command
-# line or if he sets {@code mvnd.threads} in {@code ~/.m2/mvnd.properties}.
+# line or if they set {@code mvnd.threads} in {@code ~/.m2/mvnd.properties}.

Review comment:
       I don't think we can use _they_ and _user_ which is singular.  We could use a passive sentence though: `or if {@code mvnd.threads} is set in ...` which would be better because the value could have been set in the git repo and not directly by the user.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org