You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Loyal-Young (via GitHub)" <gi...@apache.org> on 2026/10/09 09:09:05 UTC

[PR] fix(ai): count all unread messages in transcript batches [rocketmq-dashboard]

Loyal-Young opened a new pull request, #5791:
URL: https://github.com/apache/rocketmq-dashboard/pull/5791

   ## What is the purpose of the change
   Fixes #5784. Count every new transcript bubble when a batch arrives while the reader is scrolled away from the bottom.
   
   ## Brief changelog
   - Increase unread by the positive bubble-count difference.
   - Retain the existing handling for streaming updates, removals, conversation changes, and jumping to latest.
   - Add a batch regression that also checks equal-size updates, removals, a subsequent batch, and viewport stability.
   
   ## Verifying this change
   - New regression failed on the original code: expected 3 unread messages, received 1.
   - All 12 ChatThread tests passed with the fix.
   - TypeScript app check, changed-file ESLint, and git diff --check passed.
   - Full app build and backend tests were not rerun.
   
   ## AI assistance
   AI assisted with tracing the badge calculation, drafting the regression and arithmetic correction, and reviewing the test results.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ai): count all unread messages in transcript batches [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #5791: fix(ai): count all unread messages in transcript batches
URL: https://github.com/apache/rocketmq-dashboard/pull/5791


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ai): count all unread messages in transcript batches [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #5791:
URL: https://github.com/apache/rocketmq-dashboard/pull/5791#issuecomment-6093612180

   Merged as part of #5793 (squashed into `rocketmq-studio` as 29fe48abc).
   
   We are consolidating same-author changes into one commit rather than landing several near-identical ones on the trunk; your commit stays visible on this pull request and is credited in the merge body. Closing - no action needed, and thanks for the fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org