You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/16 08:10:31 UTC

[GitHub] [hudi] YuweiXiao commented on a change in pull request #4823: [HUDI-3438] Avoid getSmallFiles if hoodie.parquet.small.file.limit is 0

YuweiXiao commented on a change in pull request #4823:
URL: https://github.com/apache/hudi/pull/4823#discussion_r807650172



##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java
##########
@@ -165,7 +165,7 @@ private void assignInserts(WorkloadProfile profile, HoodieEngineContext context)
 
         List<SmallFile> smallFiles =
             filterSmallFilesInClustering(partitionPathToPendingClusteringFileGroupsId.getOrDefault(partitionPath, Collections.emptySet()),
-                partitionSmallFilesMap.get(partitionPath));
+                partitionSmallFilesMap.getOrDefault(partitionPath, new ArrayList<>()));

Review comment:
       Why is this necessary? Looking at the map construction, seems all partitions should have a corresponding value in the map.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org