You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "wrongtest-intellif (via GitHub)" <gi...@apache.org> on 2023/03/20 10:24:24 UTC
[GitHub] [tvm] wrongtest-intellif opened a new pull request, #14343: [TOPI] Fix data race of batch multibox detection
wrongtest-intellif opened a new pull request, #14343:
URL: https://github.com/apache/tvm/pull/14343
```python
for i in parallel(batch_size):
# ...
for l in range(4):
box_coord[l] = anchor[0, j, l]
pred_coord[l] = loc_pred[i, j * 4 + l]
```
Fix the issue that parallel batch share the same buffer space of `box_coord` and `pred_coord`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a diff in pull request #14343: [TOPI] Fix data race of batch multibox detection
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on code in PR #14343:
URL: https://github.com/apache/tvm/pull/14343#discussion_r1157680159
##########
python/tvm/topi/vision/ssd/multibox.py:
##########
@@ -230,9 +242,9 @@ def hybrid_multibox_transform_loc(cls_prob, loc_pred, anchor, clip, threshold, v
out_loc[i, valid_count[i], 0] = cls_id - 1.0
out_loc[i, valid_count[i], 1] = score
for l in range(4):
- box_coord[l] = anchor[0, j, l]
- pred_coord[l] = loc_pred[i, j * 4 + l]
- out_coord = _hybridy_transform_loc(box_coord, pred_coord, variances, clip)
+ box_coord[i, l] = anchor[0, j, l]
Review Comment:
It seems `box_coord` is the same in all threads. How about passing `anchor`, `j`, and `l` to `_hybridy_transform_loc` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #14343: [TOPI] Fix data race of batch multibox detection
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #14343:
URL: https://github.com/apache/tvm/pull/14343#issuecomment-1496143422
cc @masahi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest-intellif commented on pull request #14343: [TOPI] Fix data race of batch multibox detection
Posted by "wrongtest-intellif (via GitHub)" <gi...@apache.org>.
wrongtest-intellif commented on PR #14343:
URL: https://github.com/apache/tvm/pull/14343#issuecomment-1500354765
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest-intellif commented on a diff in pull request #14343: [TOPI] Fix data race of batch multibox detection
Posted by "wrongtest-intellif (via GitHub)" <gi...@apache.org>.
wrongtest-intellif commented on code in PR #14343:
URL: https://github.com/apache/tvm/pull/14343#discussion_r1158739640
##########
python/tvm/topi/vision/ssd/multibox.py:
##########
@@ -230,9 +242,9 @@ def hybrid_multibox_transform_loc(cls_prob, loc_pred, anchor, clip, threshold, v
out_loc[i, valid_count[i], 0] = cls_id - 1.0
out_loc[i, valid_count[i], 1] = score
for l in range(4):
- box_coord[l] = anchor[0, j, l]
- pred_coord[l] = loc_pred[i, j * 4 + l]
- out_coord = _hybridy_transform_loc(box_coord, pred_coord, variances, clip)
+ box_coord[i, l] = anchor[0, j, l]
Review Comment:
good idea~ updated as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #14343: [TOPI] Fix data race of batch multibox detection
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on PR #14343:
URL: https://github.com/apache/tvm/pull/14343#issuecomment-1497994130
Need to fix lint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14343: [TOPI] Fix data race of batch multibox detection
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14343:
URL: https://github.com/apache/tvm/pull/14343#issuecomment-1475971341
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to tag found in teams: `topi` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest-intellif commented on pull request #14343: [TOPI] Fix data race of batch multibox detection
Posted by "wrongtest-intellif (via GitHub)" <gi...@apache.org>.
wrongtest-intellif commented on PR #14343:
URL: https://github.com/apache/tvm/pull/14343#issuecomment-1493228948
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest-intellif commented on pull request #14343: [TOPI] Fix data race of batch multibox detection
Posted by "wrongtest-intellif (via GitHub)" <gi...@apache.org>.
wrongtest-intellif commented on PR #14343:
URL: https://github.com/apache/tvm/pull/14343#issuecomment-1496134562
cc @kevinthesun @Laurawly @tqchen Hi~ could you kindly take a look at it, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #14343: [TOPI] Fix data race of batch multibox detection
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on PR #14343:
URL: https://github.com/apache/tvm/pull/14343#issuecomment-1499758249
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #14343: [TOPI] Fix data race of batch multibox detection
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi merged PR #14343:
URL: https://github.com/apache/tvm/pull/14343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org