You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jmesnil <gi...@git.apache.org> on 2018/08/06 12:15:06 UTC
[GitHub] activemq-artemis pull request #2215: [ARTEMIS-1947]� Session metadata in ses...
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/2215
[ARTEMIS-1947] Session metadata in session management operation
Fill the session's metadata in JSON properties instead of serializing it
as an opaque String.
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1947
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmesnil/activemq-artemis ARTEMIS-1947_JSON_serialization
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2215.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2215
----
commit fd9aad202bbac331a14d6ff58c0546c5d027aa06
Author: Jeff Mesnil <jm...@...>
Date: 2018-08-06T12:11:40Z
[ARTEMIS-1947] Session metadata in session management operation
Fill the session's metadata in JSON properties instead of serializing it
as an opaque String.
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1947
----
---
[GitHub] activemq-artemis issue #2215: [ARTEMIS-1947]� Session metadata in session ma...
Posted by jmesnil <gi...@git.apache.org>.
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/2215
@jbertram Could you please reopen https://issues.apache.org/jira/browse/ARTEMIS-1947 as this patch ensures that session's metadata can actually be inspected and processed by client management code?
---
[GitHub] activemq-artemis issue #2215: [ARTEMIS-1947]� Session metadata in session ma...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2215
I just sent #2216 to deal with the failures. I must have had a brain fart or something with the metadata stuff. Your solution is much better. Thanks for the PR!
---
[GitHub] activemq-artemis issue #2215: [ARTEMIS-1947]� Session metadata in session ma...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2215
I merged this, but just realized that it breaks the existing tests in `org.apache.activemq.artemis.tests.integration.management.ActiveMQServerControlTest`. I'll send another PR to fix those.
---
[GitHub] activemq-artemis pull request #2215: [ARTEMIS-1947]� Session metadata in ses...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2215
---