You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2016/04/29 06:12:34 UTC
[GitHub] metamodel pull request: METAMODEL-244: Added support for Excel dat...
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/99
METAMODEL-244: Added support for Excel datastore as well
I realised that although METAMODEL-244 was 'fixed', I had not applied the technique to the 'Excel' module. This PR does that.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel feature/excel-column-name-mapping
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/99.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #99
----
commit 1349dc090b8ef8173d91f302e601a94dd1104555
Author: Kasper Sørensen <i....@gmail.com>
Date: 2016-04-29T04:11:50Z
METAMODEL-244: Added support for Excel datastore as well
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-244: Added support for Excel dat...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/99#issuecomment-218893382
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-244: Added support for Excel dat...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/99#discussion_r63100869
--- Diff: couchdb/src/test/java/org/apache/metamodel/couchdb/CouchDbDataContextTest.java ---
@@ -53,7 +53,8 @@ protected void setUp() throws Exception {
super.setUp();
if (isConfigured()) {
- httpClient = new StdHttpClient.Builder().host(getHostname()).build();
+ final int timeout = 8 * 1000; // 8 seconds should be more than enough
--- End diff --
- D'oh, and this is a test. Scratch both parts of that comment :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-244: Added support for Excel dat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/99
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-244: Added support for Excel dat...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/99#discussion_r63100757
--- Diff: couchdb/src/test/java/org/apache/metamodel/couchdb/CouchDbDataContextTest.java ---
@@ -53,7 +53,8 @@ protected void setUp() throws Exception {
super.setUp();
if (isConfigured()) {
- httpClient = new StdHttpClient.Builder().host(getHostname()).build();
+ final int timeout = 8 * 1000; // 8 seconds should be more than enough
--- End diff --
`public static final SOCKET_TIMEOUT`?
(I have a great hate for socket timeout settings, because they always seems so arbitrary, and it's hard to find a good number, especially in our case where we really don't know what the use case will be... I guess that's a sign that we at some point should make these user configurable)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---