[GitHub] thrift pull request #1388: THRIFT-4355 Fix javascript indentation of default...

[bforbis <gi...@git.apache.org>]

GitHub user bforbis opened a pull request:

    https://github.com/apache/thrift/pull/1388

    THRIFT-4355 Fix javascript indentation of default values

    Using the following test thrift file to test indentation in generated ttypes output.
    
    
    ```struct Object {
      1: map<string, string> hashWithDefault = {"foo": "bar", "baz": "bat"}
      2: list<string> arrayWithDefault = ["foo", "bar", "baz"]
      3: OtherObject otherObject
      4: string foostring
    }
    struct OtherObject {
      1: Object objectWithDefault = {"hashWithDefault": {"baz": "bat", "bam": "bot"}, "arrayWithDefault": ["a", "b", "c"], "foostring": "foostringvalue"
      2: string primitiveStringType
    }


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bforbis/thrift THRIFT-4355-javascript-indentation-incorrect

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1388.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1388
    
----
commit a2dbbfd0fe8e4b74ea78a4a7c46903c6f28fa737
Author: Brian Forbis <bf...@athenahealth.com>
Date:   2017-10-07T23:57:40Z

    THRIFT-4355 Fix javascript indentation of default values

----


---

[GitHub] thrift pull request #1388: THRIFT-4355 Fix javascript indentation of default...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1388


---