You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/09 02:55:39 UTC
[GitHub] [flink] hehuiyuan opened a new pull request #13566: [kafka connector]Fix cast question for properies() method in kafka ConnectorDescriptor
hehuiyuan opened a new pull request #13566:
URL: https://github.com/apache/flink/pull/13566
## What is the purpose of the change
This pull resquest fixes Kafka connector. There is a cast problem when use properties method.
```
Properties props = new Properties();
props.put( "enable.auto.commit", "false");
props.put( "fetch.max.wait.ms", "3000");
props.put("flink.poll-timeout", 5000);
props.put( "flink.partition-discovery.interval-millis", false);
kafka = new Kafka()
.version("0.11")
.topic(topic)
.properties(props);
```
```
Exception in thread "main" java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.String
Exception in thread "main" java.lang.ClassCastException: java.lang.Boolean cannot be cast to java.lang.String
```
## Brief change log
- *change (String) v ----> String.valueOf() in Kafka.java*
## Documentation
- Does this pull request introduce a new feature? ( no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13566: [kafka connector]Fix cast question for properies() method in kafka ConnectorDescriptor
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13566:
URL: https://github.com/apache/flink/pull/13566#issuecomment-705941691
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b139f0662c5c86ae97742c6dc6742aaef4f97a97",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7013",
"triggerID" : "b139f0662c5c86ae97742c6dc6742aaef4f97a97",
"triggerType" : "PUSH"
}, {
"hash" : "b139f0662c5c86ae97742c6dc6742aaef4f97a97",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7311",
"triggerID" : "b139f0662c5c86ae97742c6dc6742aaef4f97a97",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b139f0662c5c86ae97742c6dc6742aaef4f97a97 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7013) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7311)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13566: [kafka connector]Fix cast question for properies() method in kafka ConnectorDescriptor
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13566:
URL: https://github.com/apache/flink/pull/13566#issuecomment-705941691
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b139f0662c5c86ae97742c6dc6742aaef4f97a97",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7013",
"triggerID" : "b139f0662c5c86ae97742c6dc6742aaef4f97a97",
"triggerType" : "PUSH"
}, {
"hash" : "b139f0662c5c86ae97742c6dc6742aaef4f97a97",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7311",
"triggerID" : "b139f0662c5c86ae97742c6dc6742aaef4f97a97",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b139f0662c5c86ae97742c6dc6742aaef4f97a97 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7013) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7311)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13566: [kafka connector]Fix cast question for properies() method in kafka ConnectorDescriptor
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13566:
URL: https://github.com/apache/flink/pull/13566#issuecomment-705938959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13566: [kafka connector]Fix cast question for properies() method in kafka ConnectorDescriptor
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13566:
URL: https://github.com/apache/flink/pull/13566#issuecomment-705938959
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b139f0662c5c86ae97742c6dc6742aaef4f97a97 (Fri Oct 09 02:58:04 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13566: [kafka connector]Fix cast question for properies() method in kafka ConnectorDescriptor
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13566:
URL: https://github.com/apache/flink/pull/13566#issuecomment-705941691
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hehuiyuan closed pull request #13566: [kafka connector]Fix cast question for properies() method in kafka ConnectorDescriptor
Posted by GitBox <gi...@apache.org>.
hehuiyuan closed pull request #13566:
URL: https://github.com/apache/flink/pull/13566
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13566: [kafka connector]Fix cast question for properies() method in kafka ConnectorDescriptor
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13566:
URL: https://github.com/apache/flink/pull/13566#issuecomment-705941691
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b139f0662c5c86ae97742c6dc6742aaef4f97a97",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b139f0662c5c86ae97742c6dc6742aaef4f97a97",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b139f0662c5c86ae97742c6dc6742aaef4f97a97 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org