You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "varun-bhardwaj-sde (via GitHub)" <gi...@apache.org> on 2025/02/20 13:41:42 UTC
[PR] Fixed Migrate Datetime functions to invoke_with_args Issue 14705 [datafusion]
varun-bhardwaj-sde opened a new pull request, #14792:
URL: https://github.com/apache/datafusion/pull/14792
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #14705.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fixed Migrate Datetime functions to invoke_with_args Issue 14705 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #14792:
URL: https://github.com/apache/datafusion/pull/14792#issuecomment-2674391408
Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fixed Migrate Datetime functions to invoke_with_args Issue 14705 [datafusion]
Posted by "varun-bhardwaj-sde (via GitHub)" <gi...@apache.org>.
varun-bhardwaj-sde commented on PR #14792:
URL: https://github.com/apache/datafusion/pull/14792#issuecomment-2671561680
sir @goldmedal @alamb i am new in rust and this will be my first contribution please check my code and let me know if it is right or wrong ,i want to merge this change if there are any issue please let me know i will change them accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fixed Migrate Datetime functions to invoke_with_args Issue 14705 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #14792:
URL: https://github.com/apache/datafusion/pull/14792#issuecomment-2674391632
Thank you @niebayes for helping with the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fixed Migrate Datetime functions to invoke_with_args Issue 14705 [datafusion]
Posted by "varun-bhardwaj-sde (via GitHub)" <gi...@apache.org>.
varun-bhardwaj-sde closed pull request #14792: Fixed Migrate Datetime functions to invoke_with_args Issue 14705
URL: https://github.com/apache/datafusion/pull/14792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fixed Migrate Datetime functions to invoke_with_args Issue 14705 [datafusion]
Posted by "varun-bhardwaj-sde (via GitHub)" <gi...@apache.org>.
varun-bhardwaj-sde commented on PR #14792:
URL: https://github.com/apache/datafusion/pull/14792#issuecomment-2680505232
it was closed by misktake i raised another PR https://github.com/apache/datafusion/pull/14864 for this task
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fixed Migrate Datetime functions to invoke_with_args Issue 14705 [datafusion]
Posted by "niebayes (via GitHub)" <gi...@apache.org>.
niebayes commented on code in PR #14792:
URL: https://github.com/apache/datafusion/pull/14792#discussion_r1964634594
##########
datafusion/functions/src/datetime/current_date.rs:
##########
@@ -81,16 +81,19 @@ impl ScalarUDFImpl for CurrentDateFunc {
Ok(Date32)
}
- fn invoke_batch(
- &self,
- _args: &[ColumnarValue],
- _number_rows: usize,
- ) -> Result<ColumnarValue> {
- internal_err!(
- "invoke should not be called on a simplified current_date() function"
- )
+ fn invoke_with_args(&self, args: &[ColumnarValue]) -> Result<ColumnarValue> {
Review Comment:
The signature of the `invoke_with_args` should be:
```
fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue>.
```
You can check the `ScalarUDFImpl` trait in the datafusion::expr::udf crate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fixed Migrate Datetime functions to invoke_with_args Issue 14705 [datafusion]
Posted by "goldmedal (via GitHub)" <gi...@apache.org>.
goldmedal commented on PR #14792:
URL: https://github.com/apache/datafusion/pull/14792#issuecomment-2671594771
> sir @goldmedal @alamb i am new in rust and this will be my first contribution please check my code and let me know if it is right or wrong ,i want to merge this change if there are any issue please let me know i will change them accordingly
Welcome @varun-bhardwaj-sde. I enabled the CI. Some errors need to be fixed. I'll go over this after you're done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org