You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by jo...@apache.org on 2018/10/05 10:12:12 UTC

svn commit: r1842881 - /httpd/httpd/trunk/modules/proxy/ajp_header.c

Author: jorton
Date: Fri Oct  5 10:12:12 2018
New Revision: 1842881

URL: http://svn.apache.org/viewvc?rev=1842881&view=rev
Log:
* modules/proxy/ajp_header.c (sc_for_req_header): Zero-initialize
  buffer to avoid potential (harmless) memcmp comparison against
  garbage stack data later.  (clang warning).

Modified:
    httpd/httpd/trunk/modules/proxy/ajp_header.c

Modified: httpd/httpd/trunk/modules/proxy/ajp_header.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/ajp_header.c?rev=1842881&r1=1842880&r2=1842881&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/proxy/ajp_header.c (original)
+++ httpd/httpd/trunk/modules/proxy/ajp_header.c Fri Oct  5 10:12:12 2018
@@ -59,6 +59,7 @@ static int sc_for_req_header(const char
     if (len < 4 || len > 15)
         return UNKNOWN_METHOD;
 
+    memset(header, 0, sizeof header);
     while (*p)
         header[i++] = apr_toupper(*p++);
     header[i] = '\0';