You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ad...@apache.org on 2016/03/04 11:01:40 UTC
[2/3] james-project git commit: JAMES-1699 spec: mark
setMessages/send message as implemented
JAMES-1699 spec: mark setMessages/send message as implemented
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/7d25d879
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/7d25d879
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/7d25d879
Branch: refs/heads/master
Commit: 7d25d879745e1c123c3715434408b51718714b04
Parents: bf65ad9
Author: Fabien Vignon <fv...@linagora.com>
Authored: Thu Mar 3 15:43:02 2016 +0100
Committer: Fabien Vignon <fv...@linagora.com>
Committed: Fri Mar 4 10:51:54 2016 +0100
----------------------------------------------------------------------
.../james/jmap/methods/SetMessagesMethodTest.java | 18 +++++++++---------
server/protocols/jmap/doc/specs/spec/message.mdwn | 1 -
2 files changed, 9 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/james-project/blob/7d25d879/server/protocols/jmap-integration-testing/src/test/java/org/apache/james/jmap/methods/SetMessagesMethodTest.java
----------------------------------------------------------------------
diff --git a/server/protocols/jmap-integration-testing/src/test/java/org/apache/james/jmap/methods/SetMessagesMethodTest.java b/server/protocols/jmap-integration-testing/src/test/java/org/apache/james/jmap/methods/SetMessagesMethodTest.java
index fa16c1f..1828097 100644
--- a/server/protocols/jmap-integration-testing/src/test/java/org/apache/james/jmap/methods/SetMessagesMethodTest.java
+++ b/server/protocols/jmap-integration-testing/src/test/java/org/apache/james/jmap/methods/SetMessagesMethodTest.java
@@ -72,9 +72,9 @@ public abstract class SetMessagesMethodTest {
private static final String NAME = "[0][0]";
private static final String ARGUMENTS = "[0][1]";
- public static final String SECOND_NAME = "[1][0]";
- public static final String SECOND_ARGUMENTS = "[1][1]";
- public static final String USERS_DOMAIN = "domain.tld";
+ private static final String SECOND_NAME = "[1][0]";
+ private static final String SECOND_ARGUMENTS = "[1][1]";
+ private static final String USERS_DOMAIN = "domain.tld";
private final TemporaryFolder temporaryFolder = new TemporaryFolder();
private final EmbeddedElasticSearch embeddedElasticSearch = new EmbeddedElasticSearch();
@@ -670,7 +670,7 @@ public abstract class SetMessagesMethodTest {
" \"setMessages\","+
" {" +
" \"create\": { \"" + messageCreationId + "\" : {" +
- " \"from\": { \"name\": \"MAILER-DEAMON\", \"email\": \"postmaster@example.com\"}," +
+ " \"from\": { \"name\": \"MAILER-DAEMON\", \"email\": \"postmaster@example.com\"}," +
" \"to\": [{ \"name\": \"BOB\", \"email\": \"someone@example.com\"}]," +
" \"subject\": \"Thank you for joining example.com!\"," +
" \"textBody\": \"Hello someone, and thank you for joining example.com!\"," +
@@ -828,7 +828,7 @@ public abstract class SetMessagesMethodTest {
" \"setMessages\","+
" {" +
" \"create\": { \"" + messageCreationId + "\" : {" +
- " \"from\": { \"name\": \"MAILER-DEAMON\", \"email\": \"postmaster@example.com\"}," +
+ " \"from\": { \"name\": \"MAILER-DAEMON\", \"email\": \"postmaster@example.com\"}," +
" \"to\": [{ \"name\": \"BOB\", \"email\": \"someone@example.com@example.com\"}]," +
" \"cc\": [{ \"name\": \"ALICE\"}]," +
" \"subject\": \"Thank you for joining example.com!\"," +
@@ -984,7 +984,7 @@ public abstract class SetMessagesMethodTest {
" \"setMessages\","+
" {" +
" \"create\": { \"" + messageCreationId + "\" : {" +
- " \"from\": { \"name\": \"MAILER-DEAMON\", \"email\": \"postmaster@example.com\"}," +
+ " \"from\": { \"name\": \"MAILER-DAEMON\", \"email\": \"postmaster@example.com\"}," +
" \"to\": [{ \"name\": \"BOB\", \"email\": \"someone@example.com\"}]," +
" \"cc\": [{ \"name\": \"ALICE\"}]," +
" \"textBody\": \"Hello someone, and thank you for joining example.com!\"," +
@@ -1015,7 +1015,7 @@ public abstract class SetMessagesMethodTest {
}
@Test
- public void setMessagesShouldPushMessageIntoRecipientUsersInbox() throws Exception {
+ public void setMessagesShouldDeliverMessageToRecipient() throws Exception {
// Sender
jmapServer.serverProbe().createMailbox(MailboxConstants.USER_NAMESPACE, username, "sent");
// Recipient
@@ -1056,10 +1056,10 @@ public abstract class SetMessagesMethodTest {
.post("/jmap");
// Then
- calmlyAwait.atMost(10, TimeUnit.SECONDS).until( () -> messageHaveBeenDeliveredToRecipientsInbox(recipientToken));
+ calmlyAwait.atMost(10, TimeUnit.SECONDS).until( () -> isAnyMessageFoundInRecipientsMailboxes(recipientToken));
}
- private boolean messageHaveBeenDeliveredToRecipientsInbox(AccessToken recipientToken) {
+ private boolean isAnyMessageFoundInRecipientsMailboxes(AccessToken recipientToken) {
try {
with()
.accept(ContentType.JSON)
http://git-wip-us.apache.org/repos/asf/james-project/blob/7d25d879/server/protocols/jmap/doc/specs/spec/message.mdwn
----------------------------------------------------------------------
diff --git a/server/protocols/jmap/doc/specs/spec/message.mdwn b/server/protocols/jmap/doc/specs/spec/message.mdwn
index 727c874..2c65069 100644
--- a/server/protocols/jmap/doc/specs/spec/message.mdwn
+++ b/server/protocols/jmap/doc/specs/spec/message.mdwn
@@ -250,7 +250,6 @@ The *setMessages* method encompasses:
- Creating a draft message
<aside class="warning">Not implemented</aside>
- Sending a message
-<aside class="warning">Not implemented</aside>
- Changing the flags of a message (unread/flagged status)
- Adding/removing a message to/from mailboxes (moving a message)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org