[GitHub] [kafka] hachikuji commented on pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

[GitBox <gi...@apache.org>]

hachikuji commented on pull request #8822:
URL: https://github.com/apache/kafka/pull/8822#issuecomment-645526618


   @mumrah Hmm, we have the following check in `initializeCompletedFetch`:
   ```java
               if (!subscriptions.hasValidPosition(tp)) {
                   // this can happen when a rebalance happened while fetch is still in-flight
                   log.debug("Ignoring fetched records for partition {} since it no longer has valid position", tp);
               } else if (error == Errors.NONE) {
   ```
   Are you suggesting we may want to remove this check?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org