You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by nchammas <gi...@git.apache.org> on 2014/09/17 22:57:09 UTC
[GitHub] spark pull request: [SPARK-1455] Fix expansion of testing argument...
GitHub user nchammas opened a pull request:
https://github.com/apache/spark/pull/2437
[SPARK-1455] Fix expansion of testing arguments to sbt
Testing arguments to `sbt` need to be passed as an array, not a single, long string.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nchammas/spark selective-testing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2437.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2437
----
commit d4c5f438f4bb46d223f36f28c7394210c9d2fa2b
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-06T03:21:16Z
Merge pull request #6 from apache/master
merge upstream changes
commit 03180a4e9dc8f949b8d3372c54738547ca3813c1
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-10T23:39:14Z
Merge branch 'master' of github.com:nchammas/spark
commit 8051486bbfd13dbab17b30c89ef5b4ce49d3460b
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-16T02:22:18Z
Merge pull request #1 from apache/master
merge upstream changes
commit 0b47ca4b8c3497913c3eb5db3c30e63248491938
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-16T02:27:19Z
Merge branch 'master' of github.com:nchammas/spark
commit e33b9787d24c52dd33b71a83c42b0a8f7033ff5e
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-17T20:48:48Z
Merge pull request #2 from apache/master
merge upstream changes
commit cf57cbf6891c41aa9e3f6e9596802326219c4047
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-17T19:39:49Z
fix sbt test arguments
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3534] Fix expansion of testing argument...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2437#issuecomment-55960009
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20489/consoleFull) for PR 2437 at commit [`cf57cbf`](https://github.com/apache/spark/commit/cf57cbf6891c41aa9e3f6e9596802326219c4047).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3534] Fix expansion of testing argument...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2437#issuecomment-55968474
Merged, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3534] Fix expansion of testing argument...
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2437#issuecomment-55961238
cc @marmbrus
After merging, I suggest trying this out with a dummy SQL PR. I have to head out now, but I'll be online later tonight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3534] Fix expansion of testing argument...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2437#issuecomment-55968592
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20490/consoleFull) for PR 2437 at commit [`a9f9c1c`](https://github.com/apache/spark/commit/a9f9c1cbbb49ab4354cc161e17d67d9eac48de61).
* This patch **passes** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3534] Fix expansion of testing argument...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2437#issuecomment-55968142
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20489/consoleFull) for PR 2437 at commit [`cf57cbf`](https://github.com/apache/spark/commit/cf57cbf6891c41aa9e3f6e9596802326219c4047).
* This patch **passes** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3534] Fix expansion of testing argument...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2437
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3534] Fix expansion of testing argument...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2437#issuecomment-55960641
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20490/consoleFull) for PR 2437 at commit [`a9f9c1c`](https://github.com/apache/spark/commit/a9f9c1cbbb49ab4354cc161e17d67d9eac48de61).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org