[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #7420: GEODE-10067: Optimize wan-copy region command

[GitBox <gi...@apache.org>]

kohlmu-pivotal commented on a change in pull request #7420:
URL: https://github.com/apache/geode/pull/7420#discussion_r821256330



##########
File path: geode-wan/src/main/java/org/apache/geode/management/internal/cli/functions/WanCopyRegionFunctionDelegate.java
##########
@@ -184,9 +186,9 @@ public CliFunctionResult wanCopyRegion(InternalCache cache, String memberName,
     return batch;
   }
 
-  private List<?> getEntries(Region<?, ?> region, GatewaySender sender) {
+  private Collection<?> getEntries(Region<?, ?> region, GatewaySender sender) {
     if (region instanceof PartitionedRegion && sender.isParallel()) {
-      return ((PartitionedRegion) region).getDataStore().getEntries();
+      return PartitionRegionHelper.getLocalPrimaryData(region).entrySet();

Review comment:
       Definitely a much better set of data, compared to ALL data entries :D




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org