You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/12 22:39:36 UTC

[GitHub] [pulsar] kaushik-develop opened a new pull request #10203: [Issue 10202][pulsar-broker] Update the authentication data when an authentication refresh happens

kaushik-develop opened a new pull request #10203:
URL: https://github.com/apache/pulsar/pull/10203


   <!--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   Fixes #10202
   
   ### Motivation
   
   A pulsar broker does not refresh authentication data when an authentication state completes and a refresh happens. This change is to fix the issue.
   Without this fix, the server can be seen to continue using stale auth data.
   
   ### Modifications
   
   - Use the new authData when an authentication state changes to "complete" 
   - In the producer/consumer classes, do not cache the authData; get it from the connection
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   - Added an integration test [testExpiringTokenWithRefreshAndProducerRestart()] to verify
   
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema:  no 
     - The default values of configurations:  no
     - The wire protocol: no
     - The rest endpoints:  no
     - The admin cli options:  no
     - Anything that affects deployment: don't know
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable 
     - If a feature is not applicable for documentation, explain why? 
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #10203: [Issue 10202][pulsar-broker] Update the authentication data when an authentication refresh happens

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10203:
URL: https://github.com/apache/pulsar/pull/10203


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] kaushik-develop commented on pull request #10203: [Issue 10202][pulsar-broker] Update the authentication data when an authentication refresh happens

Posted by GitBox <gi...@apache.org>.
kaushik-develop commented on pull request #10203:
URL: https://github.com/apache/pulsar/pull/10203#issuecomment-819585931


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] kaushik-develop commented on pull request #10203: [Issue 10202][pulsar-broker] Update the authentication data when an authentication refresh happens

Posted by GitBox <gi...@apache.org>.
kaushik-develop commented on pull request #10203:
URL: https://github.com/apache/pulsar/pull/10203#issuecomment-818860582


   /pulsarbot run-failure-checks
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] kaushik-develop commented on pull request #10203: [Issue 10202][pulsar-broker] Update the authentication data when an authentication refresh happens

Posted by GitBox <gi...@apache.org>.
kaushik-develop commented on pull request #10203:
URL: https://github.com/apache/pulsar/pull/10203#issuecomment-819078904


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org