[PR] [FLINK-40111][table] Fall back to retract for a keyless sink without an upsert key [flink]

["gustavodemorais (via GitHub)" <gi...@apache.org>]

gustavodemorais opened a new pull request, #28704:
URL: https://github.com/apache/flink/pull/28704

   ## What is the purpose of the change
   
   A sink without a primary key that advertises an upsert changelog (ONLY_UPDATE_AFTER) can only apply UPDATE_AFTER when the input carries an upsert key for the downstream to fold by. When the input has no upsert key, the planner now falls back to BEFORE_AND_AFTER so the query plans as retract (when the input can produce UPDATE_BEFORE) instead of emitting an unkeyed upsert stream. Keyed-sink behavior is unchanged.
   
   ## Brief change log
   
   - Fall back to retract for a keyless sink whose input has no upsert key in canUpsertKeysWithImmutableColsSatisfyPk.
   - Switch the keyless-union DagOptimizationTest case to a retract sink and regenerate its plan.
   
   ## Verifying this change
   
   - ChangelogModeInferenceTest
   - DagOptimizationTest
   
   ## Does this pull request potentially affect one of the following parts:
   
   - Dependencies (does it add or upgrade a dependency): (no)
   - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
   - The serializers: (no)
   - The runtime per-record code paths (performance sensitive): (no)
   - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
   - The S3 file system connector: (no)
   
   ## Documentation
   
   - Does this pull request introduce a new feature? (no)
   - If yes, how is the feature documented? (not applicable)
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [x] Yes (please specify the tool below)
   
   2.1.196 (Claude Code) with Opus 4.8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-40111][table] Fall back to retract for a keyless sink without an upsert key [flink]

["twalthr (via GitHub)" <gi...@apache.org>]

twalthr merged PR #28704:
URL: https://github.com/apache/flink/pull/28704


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-40111][table] Fall back to retract for a keyless sink without an upsert key [flink]

["flinkbot (via GitHub)" <gi...@apache.org>]

flinkbot commented on PR #28704:
URL: https://github.com/apache/flink/pull/28704#issuecomment-4927230545

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "23bbe0fc5ae6b019c427f93bb35ef4e6eec5b90c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "23bbe0fc5ae6b019c427f93bb35ef4e6eec5b90c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 23bbe0fc5ae6b019c427f93bb35ef4e6eec5b90c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org