You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/08/04 08:45:37 UTC
[GitHub] [phoenix-connectors] stoty opened a new pull request #60: PHOENIX-6524 Hive Connector returns emtpy AND expression when all chi…
stoty opened a new pull request #60:
URL: https://github.com/apache/phoenix-connectors/pull/60
…ldren are pushed down
also fix incorrect phoenix.hbase.table.name property in some tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on pull request #60: PHOENIX-6524 Hive Connector returns emtpy AND expression when all chi…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #60:
URL: https://github.com/apache/phoenix-connectors/pull/60#issuecomment-893631995
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 29m 55s | master passed |
| +1 :green_heart: | compile | 1m 11s | master passed |
| +1 :green_heart: | checkstyle | 0m 17s | master passed |
| +1 :green_heart: | javadoc | 0m 28s | master passed |
| +0 :ok: | spotbugs | 2m 4s | phoenix-hive-base in master has 46 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 19m 41s | the patch passed |
| +1 :green_heart: | compile | 1m 4s | the patch passed |
| +1 :green_heart: | javac | 1m 4s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 17s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 23s | the patch passed |
| +1 :green_heart: | spotbugs | 1m 46s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 36m 53s | phoenix-hive-base in the patch failed. |
| -1 :x: | asflicense | 0m 8s | The patch generated 2 ASF License warnings. |
| | | 95m 22s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-60/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/60 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 350f35f0f177 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 53d0d18 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-60/2/artifact/yetus-general-check/output/patch-unit-phoenix-hive-base.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-60/2/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-60/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 2026 (vs. ulimit of 30000) |
| modules | C: phoenix-hive-base U: phoenix-hive-base |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-60/2/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on a change in pull request #60: PHOENIX-6524 Hive Connector returns emtpy AND expression when all chi…
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #60:
URL: https://github.com/apache/phoenix-connectors/pull/60#discussion_r683573457
##########
File path: phoenix-hive-base/src/it/java/org/apache/phoenix/hive/HivePhoenixStoreIT.java
##########
@@ -362,4 +362,60 @@ public void testTimestampPredicate() throws Exception {
createFile(sb.toString(), fullPath);
runTest(testName, fullPath);
}
+
+ @Test
+ //This SHOULD test for PHOENIX-6524 when all children of an AND expression are pushed down,
+ //and we were returning an AND expression without children to Hive.
+ //However, this bug didn't trigger in this test, only on an actual deployment
Review comment:
Yes, it fails with MR, but not with TEZ.
I have no clue why.
In any case, I've updated the comment, and stripped the superfloud columns now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on pull request #60: PHOENIX-6524 Hive Connector returns emtpy AND expression when all chi…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #60:
URL: https://github.com/apache/phoenix-connectors/pull/60#issuecomment-892546346
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 8m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 32m 25s | master passed |
| +1 :green_heart: | compile | 1m 7s | master passed |
| +1 :green_heart: | checkstyle | 0m 15s | master passed |
| +1 :green_heart: | javadoc | 0m 23s | master passed |
| +0 :ok: | spotbugs | 1m 48s | phoenix-hive-base in master has 46 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 20m 25s | the patch passed |
| +1 :green_heart: | compile | 1m 4s | the patch passed |
| +1 :green_heart: | javac | 1m 4s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 15s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 22s | the patch passed |
| +1 :green_heart: | spotbugs | 1m 55s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 31m 35s | phoenix-hive-base in the patch failed. |
| -1 :x: | asflicense | 0m 8s | The patch generated 2 ASF License warnings. |
| | | 100m 49s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-60/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/60 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux ace602460c68 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 6c0771a |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-60/1/artifact/yetus-general-check/output/patch-unit-phoenix-hive-base.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-60/1/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-60/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 1816 (vs. ulimit of 30000) |
| modules | C: phoenix-hive-base U: phoenix-hive-base |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-60/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on pull request #60: PHOENIX-6524 Hive Connector returns emtpy AND expression when all chi…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #60:
URL: https://github.com/apache/phoenix-connectors/pull/60#issuecomment-892546346
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 8m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 32m 25s | master passed |
| +1 :green_heart: | compile | 1m 7s | master passed |
| +1 :green_heart: | checkstyle | 0m 15s | master passed |
| +1 :green_heart: | javadoc | 0m 23s | master passed |
| +0 :ok: | spotbugs | 1m 48s | phoenix-hive-base in master has 46 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 20m 25s | the patch passed |
| +1 :green_heart: | compile | 1m 4s | the patch passed |
| +1 :green_heart: | javac | 1m 4s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 15s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 22s | the patch passed |
| +1 :green_heart: | spotbugs | 1m 55s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 31m 35s | phoenix-hive-base in the patch failed. |
| -1 :x: | asflicense | 0m 8s | The patch generated 2 ASF License warnings. |
| | | 100m 49s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-60/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/60 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux ace602460c68 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 6c0771a |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-60/1/artifact/yetus-general-check/output/patch-unit-phoenix-hive-base.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-60/1/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-60/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 1816 (vs. ulimit of 30000) |
| modules | C: phoenix-hive-base U: phoenix-hive-base |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-60/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty closed pull request #60: PHOENIX-6524 Hive Connector returns emtpy AND expression when all chi…
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #60:
URL: https://github.com/apache/phoenix-connectors/pull/60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] richardantal commented on a change in pull request #60: PHOENIX-6524 Hive Connector returns emtpy AND expression when all chi…
Posted by GitBox <gi...@apache.org>.
richardantal commented on a change in pull request #60:
URL: https://github.com/apache/phoenix-connectors/pull/60#discussion_r683503104
##########
File path: phoenix-hive-base/src/it/java/org/apache/phoenix/hive/HivePhoenixStoreIT.java
##########
@@ -362,4 +362,60 @@ public void testTimestampPredicate() throws Exception {
createFile(sb.toString(), fullPath);
runTest(testName, fullPath);
}
+
+ @Test
+ //This SHOULD test for PHOENIX-6524 when all children of an AND expression are pushed down,
+ //and we were returning an AND expression without children to Hive.
+ //However, this bug didn't trigger in this test, only on an actual deployment
+ public void testCompletelyEliminateAnd() throws Exception {
+ String testName = "testCompletelyEliminateAnd";
+ utility.getTestFileSystem().createNewFile(new Path(hiveLogDir, testName + ".out"));
+ createFile("1\t1\tc_h\td_h\te_h\t2020-01-30 15:10:10\t2020-01-30\th_h\t2020-01-30\tj_h\tk_h\tl_h\tm_h\tn_h\to_h\tp_h\tq_h\tr_h\ts_h\tt_h\tu_h\n", new Path(hiveOutputDir, testName + ".out").toString());
+ createFile(StringUtil.EMPTY_STRING, new Path(hiveLogDir, testName + ".out").toString());
+ StringBuilder sb = new StringBuilder();
+
+ sb.append("CREATE EXTERNAL TABLE TEST_PHX (\n"
+ + "a_h string,\n"
+ + "b_h string,\n"
+ + "c_h string,\n"
+ + "d_h string,\n"
+ + "e_h string,\n"
+ + "f_h string,\n"
+ + "g_h string,\n"
+ + "h_h string,\n"
+ + "i_h string,\n"
+ + "j_h string,\n"
+ + "k_h string,\n"
+ + "l_h string,\n"
+ + "m_h string,\n"
+ + "n_h string,\n"
+ + "o_h string,\n"
+ + "p_h string,\n"
+ + "q_h string,\n"
+ + "r_h string,\n"
+ + "s_h string,\n"
+ + "t_h string,\n"
+ + "u_h string)"
Review comment:
Do we need all of these columns?
Wouldn't it result the same outcome with only a_h b_h f_h?
##########
File path: phoenix-hive-base/src/it/java/org/apache/phoenix/hive/HivePhoenixStoreIT.java
##########
@@ -362,4 +362,60 @@ public void testTimestampPredicate() throws Exception {
createFile(sb.toString(), fullPath);
runTest(testName, fullPath);
}
+
+ @Test
+ //This SHOULD test for PHOENIX-6524 when all children of an AND expression are pushed down,
+ //and we were returning an AND expression without children to Hive.
+ //However, this bug didn't trigger in this test, only on an actual deployment
Review comment:
I've ran the newly created test without the other changes and it failed for me, despite this comment.
With the rest of the changes it passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on a change in pull request #60: PHOENIX-6524 Hive Connector returns emtpy AND expression when all chi…
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #60:
URL: https://github.com/apache/phoenix-connectors/pull/60#discussion_r683573457
##########
File path: phoenix-hive-base/src/it/java/org/apache/phoenix/hive/HivePhoenixStoreIT.java
##########
@@ -362,4 +362,60 @@ public void testTimestampPredicate() throws Exception {
createFile(sb.toString(), fullPath);
runTest(testName, fullPath);
}
+
+ @Test
+ //This SHOULD test for PHOENIX-6524 when all children of an AND expression are pushed down,
+ //and we were returning an AND expression without children to Hive.
+ //However, this bug didn't trigger in this test, only on an actual deployment
Review comment:
Yes, it fails with MR, but not with TEZ.
I have no clue why.
In any case, I've updated the comment, and stripped the superflous columns now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org