[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2593: IGNITE-19938 Sql. Improve catalog validation for columns parameters

["AMashenkov (via GitHub)" <gi...@apache.org>]

AMashenkov commented on code in PR #2593:
URL: https://github.com/apache/ignite-3/pull/2593#discussion_r1334240639


##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AlterTableAlterColumnCommand.java:
##########
@@ -153,7 +152,8 @@ private void validateColumnChange(CatalogTableColumnDescriptor origin) {
             }
         }
 
-        if (precision != null && precision != origin.precision() && origin.type() != ColumnType.DECIMAL) {
+        if (precision != null && precision != origin.precision() && (origin.type() != ColumnType.DECIMAL
+                || origin.type().precScale() == PrecisionScale.NO_NO)) {

Review Comment:
   This looks redundant, because `ColumnType.DECIMAL.precScale` equals to `PrecScale.YES_YES`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org