You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/07/01 11:34:19 UTC
[GitHub] [ignite] xtern commented on a change in pull request #9208: IGNITE-14594 UnionPlannerTest included into planner test suite.
xtern commented on a change in pull request #9208:
URL: https://github.com/apache/ignite/pull/9208#discussion_r662210691
##########
File path: modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/UnionPlannerTest.java
##########
@@ -131,21 +51,38 @@ public void testUnion() throws Exception {
"UNION " +
"SELECT * FROM table3 ";
- IgniteRel phys = physicalPlan(
- sql,
- publicSchema
- );
-
- System.out.println("+++ " + RelOptUtil.toString(phys));
-
- assertNotNull(phys);
+ assertPlan(sql, publicSchema, isInstanceOf(IgniteReduceAggregateBase.class)
+ .and(hasChildThat(isInstanceOf(Union.class)
+ .and(input(0, isTableScan(((TestTable)publicSchema.getTable("TABLE1")).name()))
Review comment:
Done, thanks.
##########
File path: modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/UnionPlannerTest.java
##########
@@ -131,21 +51,38 @@ public void testUnion() throws Exception {
"UNION " +
"SELECT * FROM table3 ";
- IgniteRel phys = physicalPlan(
- sql,
- publicSchema
- );
-
- System.out.println("+++ " + RelOptUtil.toString(phys));
-
- assertNotNull(phys);
+ assertPlan(sql, publicSchema, isInstanceOf(IgniteReduceAggregateBase.class)
+ .and(hasChildThat(isInstanceOf(Union.class)
+ .and(input(0, isTableScan(((TestTable)publicSchema.getTable("TABLE1")).name()))
+ .and(input(1, isTableScan(((TestTable)publicSchema.getTable("TABLE2")).name())))
Review comment:
Fixed, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org