You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/02/04 01:48:28 UTC

[GitHub] [kafka] guozhangwang commented on pull request #10525: KAFKA-7572: Producer should not send requests with negative partition id

guozhangwang commented on pull request #10525:
URL: https://github.com/apache/kafka/pull/10525#issuecomment-1029565310


   @predatorray Thanks for the PR. Just following @showuon 's comment, I thought about the existing `InvalidPartitionsException`, but that has some issues to be used by the producer, since it is currently extending `ApiException` which is used by the admin / raft controller as returned by the brokers, and using it in the producer would also be considered a public change. So I think for now just throwing the non-checked `illegal-argument` as a fatal error to crash the producer directly is fine.
   
   The PR needs some rebasing at the moment, otherwise it looks good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org