You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/19 12:33:06 UTC

[GitHub] [arrow] vibhatha commented on a diff in pull request #14682: ARROW-17676: [C++] [Python] User-defined tabular functions

vibhatha commented on code in PR #14682:
URL: https://github.com/apache/arrow/pull/14682#discussion_r1052151396


##########
python/pyarrow/_compute.pxd:
##########
@@ -21,11 +21,11 @@ from pyarrow.lib cimport *
 from pyarrow.includes.common cimport *
 from pyarrow.includes.libarrow cimport *
 
-cdef class ScalarUdfContext(_Weakrefable):
+cdef class UdfContext(_Weakrefable):

Review Comment:
   For the moment, let's leave this as `ScalarUdfContext`. The reason is not that you are wrong, for the moment the version we have only supports Scalr UDFs and probably Tabular UDFs with your PR. But the aggregate UDFs are work in progress (there is a PR for that too https://github.com/apache/arrow/pull/14527). Once we finalize this work, then let's see if we want to extend from `UDFContext` and write the others depending on the way the experimental API would evolve. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org