You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by dj...@apache.org on 2012/09/07 18:17:11 UTC
svn commit: r1382084 -
/felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java
Author: djencks
Date: Fri Sep 7 16:17:10 2012
New Revision: 1382084
URL: http://svn.apache.org/viewvc?rev=1382084&view=rev
Log:
FELIX-3657 ComponentFactory can get service notifications, it just doesn't do anything with them
Modified:
felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java
Modified: felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java
URL: http://svn.apache.org/viewvc/felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java?rev=1382084&r1=1382083&r2=1382084&view=diff
==============================================================================
--- felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java (original)
+++ felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java Fri Sep 7 16:17:10 2012
@@ -277,17 +277,14 @@ public class ComponentFactoryImpl extend
void update( DependencyManager dependencyManager, ServiceReference ref )
{
- throw new IllegalStateException( "Should not be called" );
}
void invokeBindMethod( DependencyManager dependencyManager, ServiceReference reference )
{
- throw new IllegalStateException( "Should not be called" );
}
void invokeUnbindMethod( DependencyManager dependencyManager, ServiceReference oldRef )
{
- throw new IllegalStateException( "Should not be called" );
}
//---------- Component interface
Re: svn commit: r1382084 -
/felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java
Posted by Felix Meschberger <fm...@adobe.com>.
Hi,
Am 10.09.2012 um 11:40 schrieb Pierre De Rop:
> Hi,
>
> FWI, I got such "should not be called" illegal state exception from the
> ComponentConcurrencyTest integration test (before the commit was made in
Ah, sorry for the noise. I now see. This is not the same as the exceptions thrown in the State classes.
Everything's fine.
Regards
Felix
> revision r1382084); and the stacktrace was:
>
> log level: 1 D=Fri Sep 07 10:15:35 CEST 2012, T=Thread-1: FrameworkEvent
> ERROR
> java.lang.IllegalStateException: Should not be called
> at
> org.apache.felix.scr.impl.manager.ComponentFactoryImpl.invokeBindMethod(ComponentFactoryImpl.java:285)
> at
> org.apache.felix.scr.impl.manager.DependencyManager.serviceAdded(DependencyManager.java:355)
> at
> org.apache.felix.scr.impl.manager.DependencyManager.serviceChanged(DependencyManager.java:163)
>
> at
> org.apache.felix.framework.util.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:932)
> at
> org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:793)
> at
> org.apache.felix.framework.util.EventDispatcher.fireServiceEvent(EventDispatcher.java:543)
> at
> org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4260)
> at org.apache.felix.framework.Felix.registerService(Felix.java:3275)
> at
> org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:346)
> at
> org.apache.felix.scr.impl.manager.AbstractComponentManager.registerService(AbstractComponentManager.java:721)
> at
> org.apache.felix.scr.impl.manager.AbstractComponentManager.registerService(AbstractComponentManager.java:704)
> at
> org.apache.felix.scr.impl.manager.AbstractComponentManager.registerComponentService(AbstractComponentManager.java:749)
> at
> org.apache.felix.scr.impl.manager.AbstractComponentManager$Unsatisfied.activate(AbstractComponentManager.java:1522)
> at
> org.apache.felix.scr.impl.manager.AbstractComponentManager.activateInternal(AbstractComponentManager.java:614)
> at
> org.apache.felix.scr.impl.manager.DependencyManager.serviceAdded(DependencyManager.java:286)
> at
> org.apache.felix.scr.impl.manager.DependencyManager.serviceChanged(DependencyManager.java:163)
>
> at
> org.apache.felix.framework.util.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:932)
> at
> org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:793)
> at
> org.apache.felix.framework.util.EventDispatcher.fireServiceEvent(EventDispatcher.java:543)
> at
> org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4260)
> at org.apache.felix.framework.Felix.registerService(Felix.java:3275)
> at
> org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:346)
> at
> org.apache.felix.scr.impl.manager.AbstractComponentManager.registerService(AbstractComponentManager.java:721)
> at
> org.apache.felix.scr.impl.manager.AbstractComponentManager.registerService(AbstractComponentManager.java:704)
> at
> org.apache.felix.scr.impl.manager.AbstractComponentManager.registerComponentService(AbstractComponentManager.java:749)
> at
> org.apache.felix.scr.impl.manager.AbstractComponentManager$Unsatisfied.activate(AbstractComponentManager.java:1522)
> at
> org.apache.felix.scr.impl.manager.AbstractComponentManager.activateInternal(AbstractComponentManager.java:614)
> at
> org.apache.felix.scr.impl.manager.ComponentFactoryImpl.newInstance(ComponentFactoryImpl.java:109)
> at
> org.apache.felix.scr.integration.components.concurrency.CFactory.run(CFactory.java:46)
> at java.lang.Thread.run(Thread.java:662)
>
>
> On Mon, Sep 10, 2012 at 9:27 AM, Felix Meschberger <fm...@adobe.com>wrote:
>
>> Hi,
>>
>> I think those were good since they hinted at potential programming issues
>> like calling State methods in unexpected states.
>>
>> Maybe IllegalStatetException is thus wrong and it should be something
>> else. But I would prefer to keep them.
>>
>> Regards
>> Felix
>>
>>
>> Am 07.09.2012 um 18:17 schrieb <dj...@apache.org> <dj...@apache.org>:
>>
>>> Author: djencks
>>> Date: Fri Sep 7 16:17:10 2012
>>> New Revision: 1382084
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1382084&view=rev
>>> Log:
>>> FELIX-3657 ComponentFactory can get service notifications, it just
>> doesn't do anything with them
>>>
>>> Modified:
>>>
>> felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java
>>>
>>> Modified:
>> felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java
>>> URL:
>> http://svn.apache.org/viewvc/felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java?rev=1382084&r1=1382083&r2=1382084&view=diff
>>>
>> ==============================================================================
>>> ---
>> felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java
>> (original)
>>> +++
>> felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java
>> Fri Sep 7 16:17:10 2012
>>> @@ -277,17 +277,14 @@ public class ComponentFactoryImpl extend
>>>
>>> void update( DependencyManager dependencyManager, ServiceReference
>> ref )
>>> {
>>> - throw new IllegalStateException( "Should not be called" );
>>> }
>>>
>>> void invokeBindMethod( DependencyManager dependencyManager,
>> ServiceReference reference )
>>> {
>>> - throw new IllegalStateException( "Should not be called" );
>>> }
>>>
>>> void invokeUnbindMethod( DependencyManager dependencyManager,
>> ServiceReference oldRef )
>>> {
>>> - throw new IllegalStateException( "Should not be called" );
>>> }
>>>
>>> //---------- Component interface
>>>
>>>
>>
>>
Re: svn commit: r1382084 - /felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java
Posted by Pierre De Rop <pi...@gmail.com>.
Hi,
FWI, I got such "should not be called" illegal state exception from the
ComponentConcurrencyTest integration test (before the commit was made in
revision r1382084); and the stacktrace was:
log level: 1 D=Fri Sep 07 10:15:35 CEST 2012, T=Thread-1: FrameworkEvent
ERROR
java.lang.IllegalStateException: Should not be called
at
org.apache.felix.scr.impl.manager.ComponentFactoryImpl.invokeBindMethod(ComponentFactoryImpl.java:285)
at
org.apache.felix.scr.impl.manager.DependencyManager.serviceAdded(DependencyManager.java:355)
at
org.apache.felix.scr.impl.manager.DependencyManager.serviceChanged(DependencyManager.java:163)
at
org.apache.felix.framework.util.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:932)
at
org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:793)
at
org.apache.felix.framework.util.EventDispatcher.fireServiceEvent(EventDispatcher.java:543)
at
org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4260)
at org.apache.felix.framework.Felix.registerService(Felix.java:3275)
at
org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:346)
at
org.apache.felix.scr.impl.manager.AbstractComponentManager.registerService(AbstractComponentManager.java:721)
at
org.apache.felix.scr.impl.manager.AbstractComponentManager.registerService(AbstractComponentManager.java:704)
at
org.apache.felix.scr.impl.manager.AbstractComponentManager.registerComponentService(AbstractComponentManager.java:749)
at
org.apache.felix.scr.impl.manager.AbstractComponentManager$Unsatisfied.activate(AbstractComponentManager.java:1522)
at
org.apache.felix.scr.impl.manager.AbstractComponentManager.activateInternal(AbstractComponentManager.java:614)
at
org.apache.felix.scr.impl.manager.DependencyManager.serviceAdded(DependencyManager.java:286)
at
org.apache.felix.scr.impl.manager.DependencyManager.serviceChanged(DependencyManager.java:163)
at
org.apache.felix.framework.util.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:932)
at
org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:793)
at
org.apache.felix.framework.util.EventDispatcher.fireServiceEvent(EventDispatcher.java:543)
at
org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4260)
at org.apache.felix.framework.Felix.registerService(Felix.java:3275)
at
org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:346)
at
org.apache.felix.scr.impl.manager.AbstractComponentManager.registerService(AbstractComponentManager.java:721)
at
org.apache.felix.scr.impl.manager.AbstractComponentManager.registerService(AbstractComponentManager.java:704)
at
org.apache.felix.scr.impl.manager.AbstractComponentManager.registerComponentService(AbstractComponentManager.java:749)
at
org.apache.felix.scr.impl.manager.AbstractComponentManager$Unsatisfied.activate(AbstractComponentManager.java:1522)
at
org.apache.felix.scr.impl.manager.AbstractComponentManager.activateInternal(AbstractComponentManager.java:614)
at
org.apache.felix.scr.impl.manager.ComponentFactoryImpl.newInstance(ComponentFactoryImpl.java:109)
at
org.apache.felix.scr.integration.components.concurrency.CFactory.run(CFactory.java:46)
at java.lang.Thread.run(Thread.java:662)
On Mon, Sep 10, 2012 at 9:27 AM, Felix Meschberger <fm...@adobe.com>wrote:
> Hi,
>
> I think those were good since they hinted at potential programming issues
> like calling State methods in unexpected states.
>
> Maybe IllegalStatetException is thus wrong and it should be something
> else. But I would prefer to keep them.
>
> Regards
> Felix
>
>
> Am 07.09.2012 um 18:17 schrieb <dj...@apache.org> <dj...@apache.org>:
>
> > Author: djencks
> > Date: Fri Sep 7 16:17:10 2012
> > New Revision: 1382084
> >
> > URL: http://svn.apache.org/viewvc?rev=1382084&view=rev
> > Log:
> > FELIX-3657 ComponentFactory can get service notifications, it just
> doesn't do anything with them
> >
> > Modified:
> >
> felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java
> >
> > Modified:
> felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java
> > URL:
> http://svn.apache.org/viewvc/felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java?rev=1382084&r1=1382083&r2=1382084&view=diff
> >
> ==============================================================================
> > ---
> felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java
> (original)
> > +++
> felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java
> Fri Sep 7 16:17:10 2012
> > @@ -277,17 +277,14 @@ public class ComponentFactoryImpl extend
> >
> > void update( DependencyManager dependencyManager, ServiceReference
> ref )
> > {
> > - throw new IllegalStateException( "Should not be called" );
> > }
> >
> > void invokeBindMethod( DependencyManager dependencyManager,
> ServiceReference reference )
> > {
> > - throw new IllegalStateException( "Should not be called" );
> > }
> >
> > void invokeUnbindMethod( DependencyManager dependencyManager,
> ServiceReference oldRef )
> > {
> > - throw new IllegalStateException( "Should not be called" );
> > }
> >
> > //---------- Component interface
> >
> >
>
>
Re: svn commit: r1382084 -
/felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java
Posted by Felix Meschberger <fm...@adobe.com>.
Hi,
I think those were good since they hinted at potential programming issues like calling State methods in unexpected states.
Maybe IllegalStatetException is thus wrong and it should be something else. But I would prefer to keep them.
Regards
Felix
Am 07.09.2012 um 18:17 schrieb <dj...@apache.org> <dj...@apache.org>:
> Author: djencks
> Date: Fri Sep 7 16:17:10 2012
> New Revision: 1382084
>
> URL: http://svn.apache.org/viewvc?rev=1382084&view=rev
> Log:
> FELIX-3657 ComponentFactory can get service notifications, it just doesn't do anything with them
>
> Modified:
> felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java
>
> Modified: felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java
> URL: http://svn.apache.org/viewvc/felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java?rev=1382084&r1=1382083&r2=1382084&view=diff
> ==============================================================================
> --- felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java (original)
> +++ felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java Fri Sep 7 16:17:10 2012
> @@ -277,17 +277,14 @@ public class ComponentFactoryImpl extend
>
> void update( DependencyManager dependencyManager, ServiceReference ref )
> {
> - throw new IllegalStateException( "Should not be called" );
> }
>
> void invokeBindMethod( DependencyManager dependencyManager, ServiceReference reference )
> {
> - throw new IllegalStateException( "Should not be called" );
> }
>
> void invokeUnbindMethod( DependencyManager dependencyManager, ServiceReference oldRef )
> {
> - throw new IllegalStateException( "Should not be called" );
> }
>
> //---------- Component interface
>
>