[GitHub] [airflow] ashb opened a new pull request #8763: Support same short flags for `create user` as 1.10 did for `user_create`

[GitBox <gi...@apache.org>]

ashb opened a new pull request #8763:
URL: https://github.com/apache/airflow/pull/8763


   This will make it easier to transition between versions.
   
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Target Github ISSUE in description if exists
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on a change in pull request #8763: Support same short flags for `create user` as 1.10 did for `user_create`

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #8763:
URL: https://github.com/apache/airflow/pull/8763#discussion_r421436123



##########
File path: airflow/cli/cli_parser.py
##########
@@ -629,41 +629,41 @@ def add_to_parser(self, parser: argparse.ArgumentParser):
     default=False)
 # users
 ARG_USERNAME = Arg(
-    ('--username',),
+    ('--username', '-u'),

Review comment:
       Let's change the order the other way around, short-option followed by long
   
   ```suggestion
       ('-u', '--username'),
   ```
   
   Current tests are also failing because of it :
   
   ```
   tests/cli/test_cli_parser.py .F
   
   ____________________ TestCli.test_arg_option_mix_short_long ____________________
   
   self = <tests.cli.test_cli_parser.TestCli testMethod=test_arg_option_mix_short_long>
   
       def test_arg_option_mix_short_long(self):
           """
           Test if the name of cli.args mix option (-s, --long) valid
           """
           optional_mix = [
               arg
               for arg in cli_args.values()
               if len(arg.flags) == 2 and arg.flags[0].startswith("-")
           ]
           for arg in optional_mix:
               self.assertIsNotNone(LEGAL_SHORT_OPTION_PATTERN.match(arg.flags[0]),
   >                                f"{arg.flags[0]} is not match")
   E           AssertionError: unexpectedly None : --username is not match
   
   tests/cli/test_cli_parser.py:63: AssertionError
   ```
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on a change in pull request #8763: Support same short flags for `create user` as 1.10 did for `user_create`

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #8763:
URL: https://github.com/apache/airflow/pull/8763#discussion_r421479923



##########
File path: airflow/cli/cli_parser.py
##########
@@ -629,41 +629,41 @@ def add_to_parser(self, parser: argparse.ArgumentParser):
     default=False)
 # users
 ARG_USERNAME = Arg(
-    ('--username',),
+    ('--username', '-u'),

Review comment:
       Whoops, will fix




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org