You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Enis Soztutar (JIRA)" <ji...@apache.org> on 2017/09/19 01:52:01 UTC

[jira] [Commented] (HBASE-18809) [C++] Templatize AsyncBatchRpcRetryingCaller Class

    [ https://issues.apache.org/jira/browse/HBASE-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170989#comment-16170989 ] 

Enis Soztutar commented on HBASE-18809:
---------------------------------------

Thanks Sudeep. 
Instead of {{std::shared_ptr<folly::Unit>}}, can we use {{folly::Unit}}? Is shared_ptr wrapper necessary for types elsewhere? 
{code}
+  return this->Batch<std::shared_ptr<hbase::Row>, std::shared_ptr<folly::Unit>>(
{code}

Why did {{ResponseConverter::GetResults}} move to the .h file? Also there is code duplication here. Can we do abstract the part that is common, and only do the changed parts? 


> [C++] Templatize AsyncBatchRpcRetryingCaller Class
> --------------------------------------------------
>
>                 Key: HBASE-18809
>                 URL: https://issues.apache.org/jira/browse/HBASE-18809
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>            Assignee: Sudeep Sunthankar
>         Attachments: HBASE-18809.HBASE-14850.v1.patch
>
>
> Objective is to templatize AsyncBatchRpcRetryingCaller class to support Get, Put, Delete etc request types and Result, Void response types.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)