You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/12/23 09:54:48 UTC

[GitHub] [fineract] ysanko-tranzzo commented on a change in pull request #1549: [DGB-627] Implement the ability to create data tables for a transaction entity

ysanko-tranzzo commented on a change in pull request #1549:
URL: https://github.com/apache/fineract/pull/1549#discussion_r547873195



##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java
##########
@@ -1350,7 +1350,12 @@ private String dataScopedSQL(final String appTable, final Long appTableId) {
             scopedSQL = "select null as officeId, null as groupId, null as clientId, null as savingsId, null as loanId, p.id as entityId from "
                     + appTable + " as p WHERE p.id = " + appTableId;
         }
-
+        if (appTable.equalsIgnoreCase("m_savings_account_transaction")) {
+            scopedSQL = "select o.id as officeId, null as groupId, null as clientId, x.id as savingsId, null as loanId, null as entityId from "
+                    + appTable + " as t " + " join m_office o on o.id = t.office_id and o.hierarchy like '"

Review comment:
       Could we move `t.office_id and o.hierarchy like ...` to WHERE clause?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org