You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@weex.apache.org by misakuo <gi...@git.apache.org> on 2017/10/10 10:57:03 UTC

[GitHub] incubator-weex pull request #780: * [android] fix flicker caused by coexiste...

GitHub user misakuo opened a pull request:

    https://github.com/apache/incubator-weex/pull/780

    * [android] fix flicker caused by coexistence of box-shadow and borde…

    As the title
    test case:
    http://dotwe.org/weex/c5cccc22fbb74f41ddaaa459e50d1639

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/misakuo/incubator-weex android-feature-boxshadow

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/780.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #780
    
----
commit e777ac8dd8f02805c5adee19364d87ee5c40bf9d
Author: misakuo <mi...@apache.org>
Date:   2017-10-10T10:20:24Z

    * [android] fix flicker caused by coexistence of box-shadow and border-radius

----


---

[GitHub] incubator-weex pull request #780: * [android] fix flicker caused by coexiste...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/780


---

[GitHub] incubator-weex issue #780: * [android] fix flicker caused by coexistence of ...

Posted by weex-bot <gi...@git.apache.org>.

Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/780
  
    
    <!--
      0 failure: 
      0 warning: 
      2 messages
      
    -->
    
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>has no jsfm file changed.</td>
        </tr>
      
    <tr>
          <td>:book:</td>
          <td>jsfm test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---

[GitHub] incubator-weex issue #780: * [android] fix flicker caused by coexistence of ...

Posted by gurisxie <gi...@git.apache.org>.

Github user gurisxie commented on the issue:

    https://github.com/apache/incubator-weex/pull/780
  
    @misakuo android unittest error，please have a look！
    --------------------------------------------------------------------------------------------------
    com.taobao.weex.ui.component.WXSwitchTest > testAddEvent FAILED
        java.lang.NullPointerException
            at com.taobao.weex.ui.component.WXComponent.clearBoxShadow(WXComponent.java:915)
            at com.taobao.weex.ui.component.WXComponent.setComponentLayoutParams(WXComponent.java:513)
            at com.taobao.weex.ui.component.WXComponent.setLayout(WXComponent.java:495)
            at com.taobao.weex.ui.component.ComponentTest.create(ComponentTest.java:55)
            at com.taobao.weex.ui.component.WXSwitchTest.setUp(WXSwitchTest.java:58)
    
    com.taobao.weex.ui.component.WXSwitchTest > testSetProperty FAILED
        java.lang.NullPointerException
            at com.taobao.weex.ui.component.WXComponent.clearBoxShadow(WXComponent.java:915)
            at com.taobao.weex.ui.component.WXComponent.setComponentLayoutParams(WXComponent.java:513)
            at com.taobao.weex.ui.component.WXComponent.setLayout(WXComponent.java:495)
            at com.taobao.weex.ui.component.ComponentTest.create(ComponentTest.java:55)
            at com.taobao.weex.ui.component.WXSwitchTest.setUp(WXSwitchTest.java:58)



---