You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/05/09 10:38:50 UTC
[GitHub] [incubator-mxnet] nickguletskii opened a new pull request #18268: [v1.x] Backport the GroupNorm implementation fix and introduce a migration path
nickguletskii opened a new pull request #18268:
URL: https://github.com/apache/incubator-mxnet/pull/18268
## Description ##
This is a backport of #18199 for MXNet 1.x that doesn't break compatibility with existing models.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [x] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [x] Add a switch that switches between the old and the new implementation.
- [x] Update the the unit test to test both implementations.
- [x] Document the operator's switch.
- [x] Document the switch in the Gluon block.
- [x] Add a warning in the Gluon interface.
## Comments ##
- Since `GroupNorm` will be moved to `npx` in MXNet 2.0, introducing a (dummy) `v2` parameter in MXNet 2.0 is not necessary, since backward compatibility will be broken anyways.
- Should this be included with MXNet 1.7?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18268: [v1.x] Backport the GroupNorm implementation fix and introduce a migration path
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18268:
URL: https://github.com/apache/incubator-mxnet/pull/18268#issuecomment-635208550
Jenkins CI successfully triggered : [windows-cpu, unix-cpu, miscellaneous, centos-gpu, unix-gpu, clang, windows-gpu, sanity, centos-cpu, website, edge]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] nickguletskii commented on pull request #18268: [v1.x] Backport the GroupNorm implementation fix and introduce a migration path
Posted by GitBox <gi...@apache.org>.
nickguletskii commented on pull request #18268:
URL: https://github.com/apache/incubator-mxnet/pull/18268#issuecomment-635208450
@mxnet-bot run ci [all]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] nickguletskii commented on pull request #18268: [v1.x] Backport the GroupNorm implementation fix and introduce a migration path
Posted by GitBox <gi...@apache.org>.
nickguletskii commented on pull request #18268:
URL: https://github.com/apache/incubator-mxnet/pull/18268#issuecomment-626184443
The linter checks are currently failing due to false positives in unrelated files: #18269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18268: [v1.x] Backport the GroupNorm implementation fix and introduce a migration path
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18268:
URL: https://github.com/apache/incubator-mxnet/pull/18268#issuecomment-626146108
Hey @nickguletskii , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [website, edge, centos-cpu, unix-cpu, centos-gpu, windows-gpu, miscellaneous, clang, unix-gpu, sanity, windows-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org