You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/04 05:05:01 UTC

[GitHub] [superset] villebro commented on pull request #16946: fix(query_object): missing series validation not raised an exception

villebro commented on pull request #16946:
URL: https://github.com/apache/superset/pull/16946#issuecomment-933145736


   LGTM, thanks for fixing my oversight @ofekisr ! Good example of the benefits of having good code coverage (I'll try to add a quick test for that)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org