You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (Jira)" <ji...@apache.org> on 2025/07/22 21:12:00 UTC

[jira] [Resolved] (THRIFT-5887) build/cmake/ should be prepended (not appended) to CMAKE_MODULE_PATH

     [ https://issues.apache.org/jira/browse/THRIFT-5887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer resolved THRIFT-5887.
--------------------------------
    Fix Version/s: 0.23.0
         Assignee: Kouhei Sutou
       Resolution: Fixed

I just merged it. If there is a better solution, feel free to revert.

> build/cmake/ should be prepended (not appended) to CMAKE_MODULE_PATH
> --------------------------------------------------------------------
>
>                 Key: THRIFT-5887
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5887
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.22.0
>            Reporter: Kouhei Sutou
>            Assignee: Kouhei Sutou
>            Priority: Minor
>             Fix For: 0.23.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> https://github.com/apache/thrift/blob/9cff8b9f5b217c143c75299939c32573ccd4c9c3/CMakeLists.txt#L38 appends {{build/cmake/}} to {{CMAKE_MODULE_PATH}}.
> If we build Apache Thrift by {{FetchContent}} https://cmake.org/cmake/help/latest/module/FetchContent.html, {{CMAKE_MODULE_PATH}} may have some extra paths. If these extra paths have the same file name in  https://github.com/apache/thrift/tree/master/build/cmake, our files aren't used.
> For example, both of Apache Arrow and Apache Thrift have {{DefineOptions.cmake}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)