You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/01 03:41:52 UTC
[GitHub] [apisix] spacewander opened a new pull request #4952: fix: avoid copying unwanted data when the domain's IP changed
spacewander opened a new pull request #4952:
URL: https://github.com/apache/apisix/pull/4952
It happened when we are handling upstream with domain inside a route.
Fix #4938
Fix #4941
Signed-off-by: spacewander <sp...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4952: fix: avoid copying unwanted data when the domain's IP changed
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4952:
URL: https://github.com/apache/apisix/pull/4952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #4952: fix: avoid copying unwanted data when the domain's IP changed
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #4952:
URL: https://github.com/apache/apisix/pull/4952#discussion_r700233928
##########
File path: t/node/upstream-node-dns.t
##########
@@ -505,3 +505,72 @@ qr/call \/hello
dns resolver domain: test.com to 127.0.0.1
proxy request to 127.0.0.(1:1980|5:1981)
/
+
+
+
+=== TEST 15: route with upstream node, the domain's IP is changed
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+ "upstream": {
+ "nodes": {
+ "test.com:1980": 1
+ },
+ "type": "roundrobin"
+ },
+ "uri": "/hello"
+ }]]
+ )
+
+ if code >= 300 then
+ ngx.status = code
+ end
+ ngx.say(body)
+ }
+ }
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 16: hit
+--- init_by_lua_block
+ require "resty.core"
+ apisix = require("apisix")
+ core = require("apisix.core")
+ apisix.http_init()
+
+ local utils = require("apisix.core.utils")
Review comment:
so there's this kind of test idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org