You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "caneff (via GitHub)" <gi...@apache.org> on 2023/09/12 16:49:36 UTC
[GitHub] [beam] caneff opened a new pull request, #28417: Make frame_base.py work with kwonly args for Pandas 2
caneff opened a new pull request, #28417:
URL: https://github.com/apache/beam/pull/28417
Most args of most methods in Pandas 2 are now kwonly. Updated frame_base.py to utilize those when doing args_to_kwargs and populate_defaults.
Also update frame.py for the few places where something is called with a positional argument that needs to be keyword in Pandas 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #28417: Make frame_base.py work with kwonly args for Pandas 2
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #28417:
URL: https://github.com/apache/beam/pull/28417#issuecomment-1716162226
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28417?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#28417](https://app.codecov.io/gh/apache/beam/pull/28417?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (758c390) into [master](https://app.codecov.io/gh/apache/beam/commit/bec94d936e9980a400dd50f5f6f009d311f0a94e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bec94d9) will **increase** coverage by `0.01%`.
> Report is 20 commits behind head on master.
> The diff coverage is `87.27%`.
```diff
@@ Coverage Diff @@
## master #28417 +/- ##
==========================================
+ Coverage 72.33% 72.35% +0.01%
==========================================
Files 682 682
Lines 100536 100565 +29
==========================================
+ Hits 72719 72760 +41
+ Misses 26239 26227 -12
Partials 1578 1578
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/28417/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/28417/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.89% <87.27%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/beam/pull/28417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://app.codecov.io/gh/apache/beam/pull/28417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `95.37% <86.95%> (+0.04%)` | :arrow_up: |
| [sdks/python/apache\_beam/dataframe/frame\_base.py](https://app.codecov.io/gh/apache/beam/pull/28417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lX2Jhc2UucHk=) | `89.45% <87.50%> (-0.13%)` | :arrow_down: |
... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/28417/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] caneff closed pull request #28417: Make frame_base.py work with kwonly args for Pandas 2
Posted by "caneff (via GitHub)" <gi...@apache.org>.
caneff closed pull request #28417: Make frame_base.py work with kwonly args for Pandas 2
URL: https://github.com/apache/beam/pull/28417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org