You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/05/14 05:36:45 UTC
[jira] Created: (CASSANDRA-174) reduce logging overhead
reduce logging overhead
-----------------------
Key: CASSANDRA-174
URL: https://issues.apache.org/jira/browse/CASSANDRA-174
Project: Cassandra
Issue Type: Improvement
Reporter: Jonathan Ellis
Fix For: 0.4
Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736670#action_12736670 ]
Jonathan Ellis commented on CASSANDRA-174:
------------------------------------------
some of the debug() lines don't have the if statement.
rather than optimizing for low line count i think we should optimize for consistency. otherwise every time we see a bare debug statement we have to think, "is this off the main path? or did someone make a careless mistake?"
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 0002-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 174_3.diff
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-174) reduce logging overhead
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-174:
-------------------------------------
Attachment: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
Cleaned up logger_.debug with isDebugEnabled
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724848#action_12724848 ]
Hudson commented on CASSANDRA-174:
----------------------------------
Integrated in Cassandra #121 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/121/])
add isDebugEnabled check for logger.debug for performance. patch by goffinet; reviewed by jbellis for
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 0002-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-174) reduce logging overhead
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-174:
-------------------------------------
Priority: Critical (was: Major)
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Priority: Critical
> Fix For: 0.4
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-174) reduce logging overhead
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-174:
-------------------------------------
Attachment: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
Rebased with trunk and no four lines of braces
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720251#action_12720251 ]
Jonathan Ellis commented on CASSANDRA-174:
------------------------------------------
and BCEL looks dead :(
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Priority: Critical
> Fix For: 0.4
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724624#action_12724624 ]
Jonathan Ellis commented on CASSANDRA-174:
------------------------------------------
It would be nice to get this in before someone starts another wide-ranging patch that would conflict with it.
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-174) reduce logging overhead
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-174:
-------------------------------------
Attachment: 0002-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
Patch with nice indentation
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 0002-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722673#action_12722673 ]
Jonathan Ellis commented on CASSANDRA-174:
------------------------------------------
When you do, let's omit the braces because it's just too distracting to use four lines as in
if ()
{
debug
}
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720250#action_12720250 ]
Jonathan Ellis commented on CASSANDRA-174:
------------------------------------------
Let's just go with if(logger.isDebugEnabled()) for now -- we can't include ASM for licensing reasons
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Priority: Critical
> Fix For: 0.4
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720258#action_12720258 ]
Sandeep Tata commented on CASSANDRA-174:
----------------------------------------
Yes, using the if(logger.isDebugEnabled()) check seems like the best option.
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Priority: Critical
> Fix For: 0.4
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736682#action_12736682 ]
Michael Greene commented on CASSANDRA-174:
------------------------------------------
> some of the debug() lines don't have the if statement
I don't think that's true. Did you apply my patch? I'm in agreement that all the paths should be covered, I was just mentioning that the new patch happens to hit some important paths--it should *cover* all paths though.
I just double-checked with:
grep --exclude="*.svn-base" -R -B 1 "\.debug" .
and I don't see anything.
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 0002-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 174_3.diff
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736708#action_12736708 ]
Jonathan Ellis commented on CASSANDRA-174:
------------------------------------------
My mistake -- what I thought were bare debugs were where you were correcting the indentation of a debug that already had an if.
committed.
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 0002-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 174_3.diff
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720737#action_12720737 ]
Jonathan Ellis commented on CASSANDRA-174:
------------------------------------------
Thinking about it some more, I think our rule of thumb should be to only add this boilerplate to debug lines that are going to add overhead on the read/write path. No sense in cluttering things up with the extra If when it only executes once in a blue moon.
I'll apply the patch with that change.
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-174) reduce logging overhead
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-174:
-------------------------------------
Attachment: 174_3.diff
This should finally finish this off. Indiscriminate application of conditional on debug logging -- but there were some good ones still in the read/write path that this catches.
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 0002-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 174_3.diff
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724784#action_12724784 ]
Jonathan Ellis commented on CASSANDRA-174:
------------------------------------------
committed.
this got the "logger_" instances but there are also some with "logger". Could you get those too? And logger_/logger.trace (the level lower than debug).
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 0002-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737082#action_12737082 ]
Hudson commented on CASSANDRA-174:
----------------------------------
Integrated in Cassandra #152 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/152/])
add isTraceEnabled checks similar to isDebugEnabled. patch by jbellis for
add more if-isDebugEnabled lines to reduce overhead when logging at INFO or higher. patch by Michael Greene; reviewed by jbellis for
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 0002-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 174_3.diff
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724691#action_12724691 ]
Chris Goffinet commented on CASSANDRA-174:
------------------------------------------
My license expired for Intellij so I can't cleanup a nice version with indentation fixed.
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720739#action_12720739 ]
Jonathan Ellis commented on CASSANDRA-174:
------------------------------------------
Hmm, there's a bunch of conflicts with the CASSANDRA-79 patches. Which isn't surprising since they both touch a ton of files.
Will you be able to rerun your script after we merge -79, Chris?
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733865#action_12733865 ]
Jonathan Ellis commented on CASSANDRA-174:
------------------------------------------
ping
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 0002-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-174) reduce logging overhead
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet reassigned CASSANDRA-174:
----------------------------------------
Assignee: Chris Goffinet
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723339#action_12723339 ]
Chris Goffinet commented on CASSANDRA-174:
------------------------------------------
Working on rebase.
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736713#action_12736713 ]
Jonathan Ellis commented on CASSANDRA-174:
------------------------------------------
also added r798980 doing the same for the trace messages.
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 0002-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 174_3.diff
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-174) reduce logging overhead
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720821#action_12720821 ]
Chris Goffinet commented on CASSANDRA-174:
------------------------------------------
Yes. Might be easier for me to just resolve conflicts after your stuff is ready. Since a lot of the work was just formatting the statements nicely. The script is pretty simple.
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-174) reduce logging overhead
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-174.
--------------------------------------
Resolution: Fixed
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 0002-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 174_3.diff
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-174) reduce logging overhead
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-174:
-------------------------------------
Attachment: (was: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch)
> reduce logging overhead
> -----------------------
>
> Key: CASSANDRA-174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-174
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch
>
>
> Logging overhead dominates workload for small column values. This can be mitigated by switching to INFO but you still have the overhead of throwing all those strings together. Some ideas here: http://surguy.net/articles/removing-log-messages.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.