You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/24 02:44:02 UTC

[GitHub] [apisix-dashboard] ShiningRush commented on pull request #588: feat: embedding static files into Go binaries

ShiningRush commented on pull request #588:
URL: https://github.com/apache/apisix-dashboard/pull/588#issuecomment-715660795


   this pr is not production ready for those reason:
   - static file path is `/dashboard`
   - it do not contain gin's `no route action` to handle `History Mode`
   - `statik` may be not the best choice for us, we can have a talk before we implement this(more detail plz refer to #594 description).
   
   It is better to embedding files after #594 merged, we can implement this feature base on it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org