You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/10/25 23:26:50 UTC

[GitHub] [druid] jihoonson commented on a change in pull request #11160: Remove IncrementalIndex template modifier

jihoonson commented on a change in pull request #11160:
URL: https://github.com/apache/druid/pull/11160#discussion_r736035641



##########
File path: processing/src/main/java/org/apache/druid/segment/incremental/OnheapIncrementalIndex.java
##########
@@ -369,6 +367,61 @@ public boolean isNull(int rowOffset, int aggOffset)
     return concurrentGet(rowOffset)[aggOffset].isNull();
   }
 
+  @Override
+  public Iterable<Row> iterableWithPostAggregations(

Review comment:
       Can you explain the reason for moving this method from `IncrementalInde` to here and `OffheapIncrementalIndex`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org