You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/04/02 03:28:03 UTC

[kudu-CR](branch-0.8.x) KUDU-1380. Fix retry for BUSY on non-FT scans

Todd Lipcon has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/2710

Change subject: KUDU-1380. Fix retry for BUSY on non-FT scans
......................................................................

KUDU-1380. Fix retry for BUSY on non-FT scans

This cleans up the code paths for error handling in Scan RPCs to make it much
easier to follow and eliminate duplicated code. In the process, it fixes a bug
where we would incorrectly re-open a tablet upon receiving SERVER_TOO_BUSY
errors. The tablet reopening behavior would result in the scanner rewinding to
the beginning of the tablet and yielding the same rows that had already
previously been returned to the user.

The test modification increases the number of rows to be scanned in the fault
tolerance test, and also adds an assertion that the number of rows returned
matches the number inserted. This would fail reliably without the bug fix.

Change-Id: I048d3aa2a163143d1637ae87281ed91f0fc5ac65
Reviewed-on: http://gerrit.cloudera.org:8080/2654
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit fd556b2fd2a4e4cf044843ab251fa3855d3e3a13)
---
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
4 files changed, 268 insertions(+), 203 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/2710/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I048d3aa2a163143d1637ae87281ed91f0fc5ac65
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-0.8.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>