You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/05/22 07:49:42 UTC
Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59436/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1600
https://issues.apache.org/jira/browse/RANGER-1600
Repository: ranger
Description
-------
In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
The enable script judges whether the user and the user group are empty to determine whether they are available. This logic is flawed.
Diffs
-----
agents-common/scripts/enable-agent.sh 76ba8f0
Diff: https://reviews.apache.org/r/59436/diff/1/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59436/#review175609
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On 五月 22, 2017, 7:49 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59436/
> -----------------------------------------------------------
>
> (Updated 五月 22, 2017, 7:49 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1600
> https://issues.apache.org/jira/browse/RANGER-1600
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
> The enable script judges whether the user and the user group are empty to determine whether they are available. This logic is flawed.
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh 76ba8f0
>
>
> Diff: https://reviews.apache.org/r/59436/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
Posted by pengjianhua <pe...@zte.com.cn>.
> On 五月 23, 2017, 9:08 a.m., Colm O hEigeartaigh wrote:
> > I'm not sure about the changed logic to be honest. If the user or group doesn't exist, wouldn't it be better to print an error message and abort?
>
> pengjianhua wrote:
> Initially, I was consistent with your idea. The original developer is to determine whether the user and the user group exist. The install file permissions were set according to the different users and user groups. It uses the length of the user and the user group string as the judgment logic in original code. This is a clear error.
>
> If the user or group doesn't exist, can the installer print an error message and abort? If you are also the point of view, I will submit this issue using this logic.
>
> Colm O hEigeartaigh wrote:
> I think instead it would be better that if a custom user/group are specified, but don't exist, then print out a warning message to the console (giving the user/group name that was specified) and proceed with the default values.
Ok. The logic you describe is consistent with the processing logic of this patch.
- pengjianhua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59436/#review175774
-----------------------------------------------------------
On 五月 23, 2017, 2:13 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59436/
> -----------------------------------------------------------
>
> (Updated 五月 23, 2017, 2:13 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1600
> https://issues.apache.org/jira/browse/RANGER-1600
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
> The enable script judges whether the user and the user group are empty to determine whether they are available. This logic is flawed.
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh 76ba8f0
>
>
> Diff: https://reviews.apache.org/r/59436/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
Posted by pengjianhua <pe...@zte.com.cn>.
> On 五月 23, 2017, 9:08 a.m., Colm O hEigeartaigh wrote:
> > I'm not sure about the changed logic to be honest. If the user or group doesn't exist, wouldn't it be better to print an error message and abort?
Initially, I was consistent with your idea. The original developer is to determine whether the user and the user group exist. The install file permissions were set according to the different users and user groups. It uses the length of the user and the user group string as the judgment logic in original code. This is a clear error.
If the user or group doesn't exist, can the installer print an error message and abort? If you are also the point of view, I will submit this issue using this logic.
- pengjianhua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59436/#review175774
-----------------------------------------------------------
On 五月 23, 2017, 2:13 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59436/
> -----------------------------------------------------------
>
> (Updated 五月 23, 2017, 2:13 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1600
> https://issues.apache.org/jira/browse/RANGER-1600
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
> The enable script judges whether the user and the user group are empty to determine whether they are available. This logic is flawed.
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh 76ba8f0
>
>
> Diff: https://reviews.apache.org/r/59436/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On May 23, 2017, 9:08 a.m., Colm O hEigeartaigh wrote:
> > I'm not sure about the changed logic to be honest. If the user or group doesn't exist, wouldn't it be better to print an error message and abort?
>
> pengjianhua wrote:
> Initially, I was consistent with your idea. The original developer is to determine whether the user and the user group exist. The install file permissions were set according to the different users and user groups. It uses the length of the user and the user group string as the judgment logic in original code. This is a clear error.
>
> If the user or group doesn't exist, can the installer print an error message and abort? If you are also the point of view, I will submit this issue using this logic.
I think instead it would be better that if a custom user/group are specified, but don't exist, then print out a warning message to the console (giving the user/group name that was specified) and proceed with the default values.
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59436/#review175774
-----------------------------------------------------------
On May 23, 2017, 2:13 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59436/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 2:13 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1600
> https://issues.apache.org/jira/browse/RANGER-1600
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
> The enable script judges whether the user and the user group are empty to determine whether they are available. This logic is flawed.
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh 76ba8f0
>
>
> Diff: https://reviews.apache.org/r/59436/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59436/#review175774
-----------------------------------------------------------
I'm not sure about the changed logic to be honest. If the user or group doesn't exist, wouldn't it be better to print an error message and abort?
- Colm O hEigeartaigh
On May 23, 2017, 2:13 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59436/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 2:13 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1600
> https://issues.apache.org/jira/browse/RANGER-1600
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
> The enable script judges whether the user and the user group are empty to determine whether they are available. This logic is flawed.
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh 76ba8f0
>
>
> Diff: https://reviews.apache.org/r/59436/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59436/#review177272
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On 五月 23, 2017, 2:13 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59436/
> -----------------------------------------------------------
>
> (Updated 五月 23, 2017, 2:13 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1600
> https://issues.apache.org/jira/browse/RANGER-1600
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
> The enable script judges whether the user and the user group are empty to determine whether they are available. This logic is flawed.
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh 76ba8f0
>
>
> Diff: https://reviews.apache.org/r/59436/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59436/
-----------------------------------------------------------
(Updated 五月 23, 2017, 2:13 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1600
https://issues.apache.org/jira/browse/RANGER-1600
Repository: ranger
Description
-------
In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
The enable script judges whether the user and the user group are empty to determine whether they are available. This logic is flawed.
Diffs (updated)
-----
agents-common/scripts/enable-agent.sh 76ba8f0
Diff: https://reviews.apache.org/r/59436/diff/2/
Changes: https://reviews.apache.org/r/59436/diff/1-2/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
Posted by pengjianhua <pe...@zte.com.cn>.
> On 五月 22, 2017, 9:58 a.m., Colm O hEigeartaigh wrote:
> > The comment "# The new code will be compatible with the original code logic." is a bit unnecessary. After the patch is applied it might confuse someone looking at the code.
Ok. I deleted the comment and updated the patch.
- pengjianhua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59436/#review175619
-----------------------------------------------------------
On 五月 22, 2017, 7:49 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59436/
> -----------------------------------------------------------
>
> (Updated 五月 22, 2017, 7:49 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1600
> https://issues.apache.org/jira/browse/RANGER-1600
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
> The enable script judges whether the user and the user group are empty to determine whether they are available. This logic is flawed.
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh 76ba8f0
>
>
> Diff: https://reviews.apache.org/r/59436/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59436/#review175619
-----------------------------------------------------------
The comment "# The new code will be compatible with the original code logic." is a bit unnecessary. After the patch is applied it might confuse someone looking at the code.
- Colm O hEigeartaigh
On May 22, 2017, 7:49 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59436/
> -----------------------------------------------------------
>
> (Updated May 22, 2017, 7:49 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1600
> https://issues.apache.org/jira/browse/RANGER-1600
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installed the hbase plugin.
> The enable script judges whether the user and the user group are empty to determine whether they are available. This logic is flawed.
>
>
> Diffs
> -----
>
> agents-common/scripts/enable-agent.sh 76ba8f0
>
>
> Diff: https://reviews.apache.org/r/59436/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>