[GitHub] [dolphinscheduler] songjianet commented on a diff in pull request #13848: [Improvement-13824][Resource Center] User can only visit resources under tenant defaultPath

["songjianet (via GitHub)" <gi...@apache.org>]

songjianet commented on code in PR #13848:
URL: https://github.com/apache/dolphinscheduler/pull/13848#discussion_r1165028368


##########
dolphinscheduler-ui/src/views/resource/index.tsx:
##########
@@ -25,4 +27,15 @@ const resource = defineComponent({
   }
 })
 
+export function getBaseDir(resourceType: ResourceType) {
+  const baseDir = ref(String(""));

Review Comment:
   Please use single quotes and remove the semicolons.



##########
dolphinscheduler-ui/src/views/resource/components/resource/index.tsx:
##########
@@ -46,6 +46,7 @@ import styles from './index.module.scss'
 import type { Router } from 'vue-router'
 import Search from "@/components/input-search"
 import { ResourceType } from "@/views/resource/components/resource/types";

Review Comment:
   Please remove the semicolon.



##########
dolphinscheduler-ui/src/views/resource/index.tsx:
##########
@@ -15,7 +15,9 @@
  * limitations under the License.
  */
 
-import { defineComponent } from 'vue'
+import { defineComponent, ref } from 'vue'
+import { queryBaseDir } from "@/service/modules/resources";

Review Comment:
   Please remove the semicolon.



##########
dolphinscheduler-ui/src/views/resource/index.tsx:
##########
@@ -15,7 +15,9 @@
  * limitations under the License.
  */
 
-import { defineComponent } from 'vue'
+import { defineComponent, ref } from 'vue'
+import { queryBaseDir } from "@/service/modules/resources";
+import { ResourceType } from "@/views/resource/components/resource/types";

Review Comment:
   Please remove the semicolon.



##########
dolphinscheduler-ui/src/views/resource/components/resource/index.tsx:
##########
@@ -46,6 +46,7 @@ import styles from './index.module.scss'
 import type { Router } from 'vue-router'
 import Search from "@/components/input-search"
 import { ResourceType } from "@/views/resource/components/resource/types";
+import { getBaseDir } from "@/views/resource";

Review Comment:
   Please remove the semicolon.



##########
dolphinscheduler-ui/src/service/modules/resources/index.ts:
##########
@@ -45,6 +45,16 @@ export function queryResourceListPaging(
   })
 }
 
+export function queryBaseDir(
+    params: ResourceTypeReq,

Review Comment:
   Please remove the comma.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org